Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditorConfig #23

Merged
Merged

Conversation

shoushou1106
Copy link

Add .editorconfig that let IDE follows CodingStandards.cs

@shoushou1106 shoushou1106 marked this pull request as ready for review October 22, 2023 13:24
@shoushou1106
Copy link
Author

shoushou1106 commented Oct 22, 2023

If reformat is inappropriate please let me know and I will roll it back(and idk why it cause conflicts)
namespace config is error now

@wannkunstbeikor
Copy link
Owner

wannkunstbeikor commented Oct 22, 2023

u need to create a branch based on my master branch, so it doesnt conflict with it, else i cant merge it.

for this u need to add my repo as a remote and then just create a new branch based on my master branch

git remote add <some name> https://github.com/wannkunstbeikor/FrostyToolsuite.git
git fetch <some name>
git branch <branch name> <some name>/master

@wannkunstbeikor
Copy link
Owner

wannkunstbeikor commented Oct 22, 2023

also im not a fan of the space after a method name and before the ()

This reverts commit 6fbc060.
@shoushou1106
Copy link
Author

@wannkunstbeikor can you merge this now? then i will make a new branch for auto reformat

@wannkunstbeikor
Copy link
Owner

wannkunstbeikor commented Oct 23, 2023

Some small changes to the config would be great.

public void Test() instead of public void Test ()

switch ()
{
    case :
    {
    }
}

instead of

switch ()
{
    case :
        {
        }
}

and

new Class
{
    Variable = 1
}

instead of new Class { Variable = 1 }

@shoushou1106
Copy link
Author

oh sorry i forgot that

@shoushou1106
Copy link
Author

new Class
{
    Variable = 1
}

instead of new Class { Variable = 1 }

sorry idk how to do that

@wannkunstbeikor
Copy link
Owner

its okay then, if we figure it out we can add it later, just commit the changes and i will merge it

@wannkunstbeikor
Copy link
Owner

i think u just need to do csharp_new_line_before_open_brace = all

@shoushou1106
Copy link
Author

its okay then, if we figure it out we can add it later, just commit the changes and i will merge it

ok you can merge it now
btw can you reformat by yourself and commit it
图片

@shoushou1106
Copy link
Author

i think u just need to do csharp_new_line_before_open_brace = all

i have already do that

@wannkunstbeikor
Copy link
Owner

also why did u change the versions of some of the editor packages

@shoushou1106
Copy link
Author

also why did u change the versions of some of the editor packages

idk, i change it back now

@wannkunstbeikor
Copy link
Owner

okay thanks a lot

@wannkunstbeikor wannkunstbeikor merged commit b7339bd into wannkunstbeikor:master Oct 23, 2023
1 check passed
@shoushou1106 shoushou1106 deleted the 2.0.0_EditorConfig branch October 23, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants