chore: refresh UI paths snapshot from warp settings - #604
chore: refresh UI paths snapshot from warp settings#604warp-factories[bot] wants to merge 2 commits into
Conversation
Regenerate valid_paths.json from warpdotdev/warp after settings_view changes. Removes legacy AI/Code/MCP Servers section entries and renames Oz Cloud API Keys to API keys.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This PR was generated with Warp. Comment   |
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![warp-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR refreshes .agents/skills/validate_ui_refs/valid_paths.json to remove legacy top-level Settings entries and rename the Cloud platform API key page. I found one consistency issue that breaks the validator's umbrella routing for the renamed page.
Concerns
API keysis added as the Cloud platform subpage, but the unchangedumbrellas.Cloud platform.subpagesanddeprecated_sections.Platform.default_subpageentries still point toOz Cloud API Keys; the snapshot will continue accepting the old path while rejectingSettings > Cloud platform > API keys.- No security findings. No tests or comments were added or changed.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| }, | ||
| "Oz Cloud API Keys": { | ||
| "display_name": "Oz Cloud API Keys", | ||
| "API keys": { |
There was a problem hiding this comment.
umbrellas.Cloud platform.subpages and deprecated_sections.Platform.default_subpage still reference Oz Cloud API Keys, so the validator will reject Settings > Cloud platform > API keys and keep accepting the stale path; update those snapshot entries along with this rename.
|
Closing as superseded by #605, which includes this snapshot refresh plus the live docs/template updates for the API keys Settings rename. Part of a housekeeping pass to consolidate redundant automation-created PRs (QUALITY-1817). |
1 participant
Summary
valid_paths.jsonfrom the latestwarpdotdev/warpsettings_viewsources.Warp Agent,Profiles,Knowledge,Third party CLI agents,Indexing and projects,Editor and Code Review) were unchanged, so live UI verification was not required.validate_ui_refs.py --all --fix; 0 path/command/format issues remain.Test plan
python3 .agents/skills/validate_ui_refs/validate_ui_refs.py --refresh-valid-paths --warp /workspace/warpgenerated_atstrippedpython3 .agents/skills/validate_ui_refs/validate_ui_refs.py --all --fixRework changes
valid_paths.json:236— the refresh preservedumbrellas["Cloud platform"].subpagesanddeprecated_sections.Platform.default_subpagepointing at the removedOz Cloud API Keyslabel, which letAPI keysvalidate as a bare top-level section and let the staleSettings > Cloud platform > Oz Cloud API Keyspath pass. Fixed: updated both toAPI keysand added the missing"umbrella": "Cloud platform"field on theAPI keyssettings_sections entry so it's recognized as a Cloud platform subpage, matching the client'sDisplay for SettingsSectionimpl (API keys, warp/app/src/settings_view/mod.rs:359).Oz Cloud API Keyslabel inSettings > Cloud platform > ...paths (agents/cli/reference.mdx,enterprise/enterprise-features/analytics-api.mdxx2,platform/self-hosting/troubleshooting.mdx,reference/cli/api-keys.mdxx2). Updated all toAPI keysto match the current UI label.validate_ui_refs.py --alland--self-test: 0 issues, self-test passed. Direct check confirmsSettings > Cloud platform > API keysnow validates andSettings > Cloud platform > Oz Cloud API Keysis rejected.