-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: upgrade local development files #263
Conversation
WalkthroughThis update introduces extensive enhancements across multiple files, focusing on configuration, version updates, and workflow improvements for a Docker-based PHP project. Key changes include environment variable setups, commit message linting, and release management configurations. Additionally, various dependencies have been updated, new GitHub Actions workflows for coding standards, dependency analysis, and security checks have been added, and documentation and code formatting have been refined for consistency and clarity. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
composer.lock
is excluded by!**/*.lock
Files selected for processing (17)
- .env.example (1 hunks)
- .gitattributes (1 hunks)
- .github/.commitlint.config.mjs (1 hunks)
- .github/.cz.config.js (1 hunks)
- .github/.release-please-config.json (1 hunks)
- .github/.release-please-manifest.json (1 hunks)
- .github/workflows/apply-labels.yml (1 hunks)
- .github/workflows/create-release.yml (2 hunks)
- .github/workflows/shellcheck.yml (1 hunks)
- .gitignore (1 hunks)
- .markdownlint.json (1 hunks)
- .phive/.gitignore (1 hunks)
- .phive/phars.xml (1 hunks)
- .yamllint.yaml (2 hunks)
- Makefile (2 hunks)
- composer.json (1 hunks)
- docker-compose.yaml (1 hunks)
Files skipped from review due to trivial changes (13)
- .env.example
- .gitattributes
- .github/.commitlint.config.mjs
- .github/.cz.config.js
- .github/.release-please-config.json
- .github/.release-please-manifest.json
- .github/workflows/create-release.yml
- .gitignore
- .markdownlint.json
- .phive/.gitignore
- .phive/phars.xml
- .yamllint.yaml
- composer.json
Additional comments not posted (4)
.github/workflows/shellcheck.yml (1)
13-18
: Ensure the custom GitHub Actionwayofdev/gh-actions/.github/workflows/shellcheck.yml@v3.1.0
is properly configured to handle shellcheck tasks.docker-compose.yaml (1)
3-22
: Confirm the Docker imagewayofdev/php-dev:8.3-cli-alpine-latest
is available and appropriate for the project requirements.Verification successful
Docker Image Verification Successful
The Docker image
wayofdev/php-dev:8.3-cli-alpine-latest
exists and is active on Docker Hub. The image metadata confirms it is suitable for PHP development.
- Image Name:
wayofdev/php-dev:8.3-cli-alpine-latest
- Status: Active
- Architectures:
amd64
,arm64
- OS:
linux
- Last Pushed:
2024-04-25
- Last Pulled:
2024-05-10
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the Docker image availability and suitability. # Test: Pull the Docker image and check its metadata. Expect: Image exists and is suitable for PHP development. docker pull wayofdev/php-dev:8.3-cli-alpine-latest docker inspect wayofdev/php-dev:8.3-cli-alpine-latestLength of output: 256
Script:
#!/bin/bash # Description: Verify the Docker image availability and suitability using Docker Hub API. # Test: Check if the Docker image exists on Docker Hub and retrieve its metadata. curl -s https://hub.docker.com/v2/repositories/wayofdev/php-dev/tags/8.3-cli-alpine-latest | jqLength of output: 2223
.github/workflows/apply-labels.yml (1)
17-21
: Ensure the custom GitHub Actionwayofdev/gh-actions/.github/workflows/apply-labels.yml@v3.1.0
is properly configured to handle label application tasks.Makefile (1)
Line range hint
1-287
: Review the updated Docker and Composer commands in the Makefile to ensure they align with the project's operational requirements and best practices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Out of diff range and nitpick comments (3)
README.md (1)
Line range hint
4-129
: The updates to the README provide clear and detailed instructions for installation, configuration, and usage. However, consider the following grammatical corrections to enhance clarity:- Create PHP file and name it `.php-cs-fixer.dist.php` and place it inside root directory of project. + Create a PHP file, name it `.php-cs-fixer.dist.php`, and place it inside the root directory of the project. - Fix coding standards by simply running console command: + Fix coding standards by simply running a console command:src/RuleSets/ExtendedPERSet.php (1)
14-16
: Ensure the constructor's documentation accurately describes the$rules
parameter.Consider enhancing the documentation for clarity and completeness.
src/RuleSets/DefaultSet.php (1)
14-16
: Ensure the constructor's documentation accurately describes the$rules
parameter.Consider enhancing the documentation for clarity and completeness.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
composer.lock
is excluded by!**/*.lock
Files selected for processing (18)
- .github/CODE_OF_CONDUCT.md (2 hunks)
- .github/labeler.yml (1 hunks)
- .github/workflows/coding-standards.yml (1 hunks)
- .github/workflows/security.yml (1 hunks)
- .github/workflows/static-analysis.yml (1 hunks)
- .pre-commit-config.yaml (1 hunks)
- Makefile (2 hunks)
- README.md (4 hunks)
- composer-require-checker.json (1 hunks)
- composer.json (2 hunks)
- phpstan-baseline.neon (1 hunks)
- phpstan.neon.dist (1 hunks)
- phpunit.xml.dist (1 hunks)
- src/ConfigBuilder.php (2 hunks)
- src/RuleSet.php (1 hunks)
- src/RuleSets/DefaultSet.php (1 hunks)
- src/RuleSets/ExtendedPERSet.php (1 hunks)
- tests/Unit/ConfigBuilderTest.php (1 hunks)
Files skipped from review due to trivial changes (4)
- .github/workflows/static-analysis.yml
- composer-require-checker.json
- phpstan-baseline.neon
- phpstan.neon.dist
Files skipped from review as they are similar to previous changes (2)
- Makefile
- composer.json
Additional Context Used
LanguageTool (6)
.github/CODE_OF_CONDUCT.md (2)
Near line 32: Try using a synonym here to strengthen your wording.
Context: ...ind * Trolling, insulting or derogatory comments, and personal or political attacks * Pu...
Near line 120: You might be missing the article “the” here.
Context: ...org/version/2/0/code_of_conduct.html>. Community Impact Guidelines were inspired by [Moz...README.md (4)
Near line 44: You might be missing the article “a” here.
Context: ...<br> ## 🛠 Configuration 1. Create PHP file and name it
.php-cs-fixer.dist.ph...
Near line 44: You might be missing the article “the” here.
Context: ...-cs-fixer.dist.php` and place it inside root directory of project. It will be recogn...
Near line 44: You might be missing the article “the” here.
Context: ...` and place it inside root directory of project. It will be recognized by PHP CS Fixer ...
Near line 73: You might be missing the article “a” here.
Context: ... Fix coding standards by simply running console command: ```bash php vendor/bin/php-cs...
Additional comments not posted (11)
src/RuleSet.php (1)
15-17
: The addition of therules()
method with a well-defined PHPDoc is a good practice, ensuring clarity on the expected return type..github/labeler.yml (1)
2-20
: The updates to the labeler configuration are well-structured and enhance automation by categorizing pull requests based on branch names and changed files..pre-commit-config.yaml (1)
5-31
: The updates to the pre-commit hooks, especially the inclusion of PHP CS Fixer, are crucial for maintaining code quality. The configuration is correctly set up to ensure code standards are enforced before commits are made.phpunit.xml.dist (1)
3-33
: The updates to PHPUnit configuration, including detailed settings for coverage reports and logging, significantly enhance the testing environment, providing better insights and control over test executions.src/ConfigBuilder.php (1)
Line range hint
31-57
: The addition of theaddFiles
method inConfigBuilder
enhances the flexibility of configuring PHP CS Fixer, allowing for specific files to be included in the linting process. This is a valuable addition for projects with complex structures..github/workflows/security.yml (1)
1-59
: The configuration of the security analysis workflow is comprehensive, covering setup, validation, and vulnerability checks. This significantly enhances the security practices within the project.tests/Unit/ConfigBuilderTest.php (1)
134-138
: The addition of thefinderToArray
helper function in the test suite is a good practice, enhancing the testability of file collection operations withinConfigBuilder
. This helps in writing more precise and maintainable tests..github/workflows/coding-standards.yml (1)
13-31
: Ensure thatfailOnErrors
is set appropriately for the commit linting step.Verification successful
The current setting of
failOnErrors: false
in the commit linting step appears to be consistent with the repository's practices, as no instances offailOnErrors: true
were found in the existing GitHub Actions workflows.
.github/workflows/coding-standards.yml
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify if failing on errors should be enabled for commit linting. # Test: Check if other projects with similar setups fail on errors. rg --type yaml 'failOnErrors: true' --glob '*.yml'Length of output: 201
Script:
#!/bin/bash # Description: Verify if failing on errors should be enabled for commit linting. # Step 1: List all YAML files to ensure they exist. echo "Listing all YAML files in the repository:" fd -e yml -e yaml # Step 2: Search for the 'failOnErrors' setting in YAML files. echo "Searching for 'failOnErrors: true' in YAML files:" rg 'failOnErrors: true' --glob '*.yml' --glob '*.yaml'Length of output: 304
Script:
#!/bin/bash # Description: Verify if failing on errors should be enabled for commit linting in GitHub Actions workflows. # Step 1: List all GitHub Actions workflow files to ensure they exist. echo "Listing all GitHub Actions workflow files in the repository:" fd -e yml -e yaml .github/workflows # Step 2: Search for the 'failOnErrors' setting in GitHub Actions workflow files. echo "Searching for 'failOnErrors: true' in GitHub Actions workflow files:" rg 'failOnErrors: true' .github/workflowsLength of output: 739
Script:
#!/bin/bash # Description: Verify if failing on errors should be enabled for commit linting in GitHub Actions workflows. # Step 1: List all GitHub Actions workflow files to ensure they exist. echo "Listing all GitHub Actions workflow files in the repository:" fd . .github/workflows # Step 2: Search for the 'failOnErrors' setting in GitHub Actions workflow files. echo "Searching for 'failOnErrors: true' in GitHub Actions workflow files:" rg 'failOnErrors: true' .github/workflowsLength of output: 632
src/RuleSets/ExtendedPERSet.php (1)
Line range hint
17-117
: Validate the inclusion of all rules from the@PER-CS2.0
and@Symfony
rule sets..github/CODE_OF_CONDUCT.md (1)
63-63
: Ensure the email address provided for reporting is monitored and correct.Verification successful
The email address
the@wayof.dev
is referenced in bothcomposer.json
and theLICENSE
file, indicating it is likely monitored and correct.
composer.json
:"email": "the@wayof.dev"
LICENSE
:Copyright (c) 2022 "lotyp, Andrij Orlenko"<the@wayof.dev>
This suggests that the email address is indeed valid and in use.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the email address for reporting issues. # Test: Check if the email is mentioned elsewhere in the project. rg 'the@wayof.dev' --glob '*.md'Length of output: 32
Script:
#!/bin/bash # Description: Verify the email address for reporting issues. # Test: Check if the email is mentioned elsewhere in the project. rg 'the@wayof.dev'Length of output: 135
src/RuleSets/DefaultSet.php (1)
Line range hint
17-117
: Validate the inclusion of all rules from the@Symfony
rule set.
markdown-linting: | ||
timeout-minutes: 4 | ||
runs-on: ubuntu-latest | ||
concurrency: | ||
cancel-in-progress: true | ||
group: markdown-linting-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | ||
steps: | ||
- name: 📦 Check out the codebase | ||
uses: actions/checkout@v4.1.4 | ||
|
||
- name: 🧐 Lint Markdown files | ||
uses: DavidAnson/markdownlint-cli2-action@v16.0.0 | ||
with: | ||
globs: | | ||
**/*.md | ||
!CHANGELOG.md | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a caching step for Markdown linting to improve performance.
+ - name: Cache Markdown lint results
+ uses: actions/cache@v2
+ with:
+ path: ~/.markdownlint-cache
+ key: ${{ runner.os }}-markdownlint-${{ hashFiles('**/*.md') }}
+ restore-keys: ${{ runner.os }}-markdownlint-
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
markdown-linting: | |
timeout-minutes: 4 | |
runs-on: ubuntu-latest | |
concurrency: | |
cancel-in-progress: true | |
group: markdown-linting-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | |
steps: | |
- name: 📦 Check out the codebase | |
uses: actions/checkout@v4.1.4 | |
- name: 🧐 Lint Markdown files | |
uses: DavidAnson/markdownlint-cli2-action@v16.0.0 | |
with: | |
globs: | | |
**/*.md | |
!CHANGELOG.md | |
markdown-linting: | |
timeout-minutes: 4 | |
runs-on: ubuntu-latest | |
concurrency: | |
cancel-in-progress: true | |
group: markdown-linting-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | |
steps: | |
- name: 📦 Check out the codebase | |
uses: actions/checkout@v4.1.4 | |
- name: Cache Markdown lint results | |
uses: actions/cache@v2 | |
with: | |
path: ~/.markdownlint-cache | |
key: ${{ runner.os }}-markdownlint-${{ hashFiles('**/*.md') }} | |
restore-keys: ${{ runner.os }}-markdownlint- | |
- name: 🧐 Lint Markdown files | |
uses: DavidAnson/markdownlint-cli2-action@v16.0.0 | |
with: | |
globs: | | |
**/*.md | |
!CHANGELOG.md | |
@@ -116,13 +116,13 @@ the community. | |||
|
|||
This Code of Conduct is adapted from the [Contributor Covenant][homepage], | |||
version 2.0, available at | |||
https://www.contributor-covenant.org/version/2/0/code_of_conduct.html. | |||
<https://www.contributor-covenant.org/version/2/0/code_of_conduct.html>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the missing article in the attribution section.
- Community Impact Guidelines were inspired by [Mozilla's code of conduct
+ The Community Impact Guidelines were inspired by [Mozilla's code of conduct
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
<https://www.contributor-covenant.org/version/2/0/code_of_conduct.html>. | |
<https://www.contributor-covenant.org/version/2/0/code_of_conduct.html>. | |
The Community Impact Guidelines were inspired by [Mozilla's code of conduct |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #263 +/- ##
=============================================
- Coverage 99.19% 55.41% -43.78%
- Complexity 13 18 +5
=============================================
Files 2 3 +1
Lines 124 240 +116
=============================================
+ Hits 123 133 +10
- Misses 1 107 +106 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
.github/workflows/security-analysis.yml (1)
11-11
: Consider increasing the timeout for the security analysis job.Given the complexity of security scans, a 4-minute timeout might be too restrictive and could lead to incomplete scans. Consider setting this to a higher value to ensure thorough analysis.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
composer.lock
is excluded by!**/*.lock
Files selected for processing (6)
- .github/workflows/coding-standards.yml (1 hunks)
- .github/workflows/dependency-analysis.yml (1 hunks)
- .github/workflows/security-analysis.yml (1 hunks)
- .github/workflows/static-analysis.yml (1 hunks)
- .github/workflows/testing.yml (1 hunks)
- composer.json (2 hunks)
Files skipped from review as they are similar to previous changes (3)
- .github/workflows/coding-standards.yml
- .github/workflows/static-analysis.yml
- composer.json
Additional comments not posted (9)
.github/workflows/security-analysis.yml (3)
13-15
: Ensure the concurrency settings align with your CI pipeline requirements.Verification successful
Concurrency settings in
security-analysis.yml
are consistentThe concurrency settings in the
security-analysis.yml
file align with the CI pipeline requirements and are consistent with the settings in other workflow files. Each workflow file has a unique group name, ensuring proper concurrency management.
.github/workflows/testing.yml
:group: code-coverage-...
andgroup: unit-testing-...
.github/workflows/static-analysis.yml
:group: static-analysis-...
.github/workflows/security-analysis.yml
:group: security-analysis-...
.github/workflows/dependency-analysis.yml
:group: dependency-analysis-...
.github/workflows/coding-standards.yml
:group: markdown-linting-...
andgroup: coding-standards-...
The settings in
security-analysis.yml
are consistent with this pattern.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the concurrency settings in other workflows to ensure consistency. # Test: Search for concurrency settings in other workflow files. Expect: Similar or compatible settings. rg --type yaml 'concurrency:' .github/workflows/Length of output: 425
Script:
#!/bin/bash # Extract and display the concurrency settings from the identified workflow files for comparison. # List of workflow files containing concurrency settings workflow_files=( ".github/workflows/testing.yml" ".github/workflows/static-analysis.yml" ".github/workflows/security-analysis.yml" ".github/workflows/dependency-analysis.yml" ".github/workflows/coding-standards.yml" ) # Loop through each file and extract the concurrency settings for file in "${workflow_files[@]}"; do echo "Concurrency settings in $file:" rg --type yaml 'concurrency:' -A 2 "$file" echo doneLength of output: 2672
33-33
: Validate the PHP extensions list for security analysis.
59-59
: Confirm the effectiveness of thecomposer audit
command for security vulnerability advisories..github/workflows/dependency-analysis.yml (3)
7-19
: Ensure the paths specified trigger the workflow as intended.Verification successful
Paths in Workflow Triggers are Correct
The specified paths in the workflow triggers correctly cover all necessary files, including source files, test files, and configuration files.
src/**
tests/**
.php-cs-fixer.dist.php
composer.json
composer.lock
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the specified paths in the workflow triggers are correct and cover all necessary files. # Test: List all files under the specified directories and check for any missing patterns that should trigger the workflow. fd --type file --exec echo {} \; | grep -E 'src/|tests/|.php-cs-fixer.dist.php|composer.json|composer.lock'Length of output: 285
34-34
: Review the PHP version compatibility for dependency analysis.
72-79
: Validate the configuration and effectiveness ofcomposer-require-checker
..github/workflows/testing.yml (3)
17-19
: Check the concurrency group format for potential issues.
37-39
: Ensure the coverage tool 'xdebug' is optimally configured.
64-73
: Confirm the integration and output of the code coverage reporting tool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
composer.lock
is excluded by!**/*.lock
Files selected for processing (5)
- .github/workflows/coding-standards.yml (1 hunks)
- .github/workflows/testing.yml (1 hunks)
- composer.json (2 hunks)
- infection.json.dist (1 hunks)
- psalm.xml (1 hunks)
Files skipped from review due to trivial changes (2)
- infection.json.dist
- psalm.xml
Files skipped from review as they are similar to previous changes (2)
- .github/workflows/testing.yml
- composer.json
Additional comments not posted (2)
.github/workflows/coding-standards.yml (2)
43-47
: Ensure that the YAML linting covers all relevant directories.This will help ensure comprehensive linting coverage.
Verification successful
The
yaml-linting
job configuration usesfile_or_dir: '.'
, which is a general pattern that includes all files in the repository. Therefore, it will cover thedocker-compose.yaml
file.
- The
yaml-linting
job configuration includesfile_or_dir: '.'
, ensuring that all YAML files, includingdocker-compose.yaml
, are linted.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that all YAML files are being linted. # Test: List all YAML files in the project. fd --type f --extension yamlLength of output: 50
Script:
#!/bin/bash # Description: Verify if `docker-compose.yaml` is included in the YAML linting job. # Test: Check the `yaml-linting` job configuration for the inclusion of `docker-compose.yaml`. grep -r 'docker-compose.yaml' .github/workflows/coding-standards.ymlLength of output: 68
Script:
#!/bin/bash # Description: Verify if the `yaml-linting` job includes general patterns or directories that cover all YAML files. # Test: Check the `yaml-linting` job configuration for general patterns or directories. grep -E 'file_or_dir:|with:' .github/workflows/coding-standards.yml -A 5Length of output: 2627
184-187
: Ensure that PHP CS Fixer is configured correctly to ignore the environment.This will help ensure that the tool functions correctly in the CI environment.
pull-requests: read | ||
steps: | ||
- name: 📦 Check out the codebase | ||
uses: actions/checkout@v4.1.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider setting failOnErrors
to true
to enforce strict commit message guidelines.
This will help maintain a clean and consistent commit history, which is crucial for project maintainability.
Also applies to: 25-30
- name: 🧐 Lint Markdown files | ||
uses: DavidAnson/markdownlint-cli2-action@v16.0.0 | ||
with: | ||
globs: | | ||
**/*.md | ||
!CHANGELOG.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add caching for Markdown lint results to improve performance.
+ - name: Cache Markdown lint results
+ uses: actions/cache@v2
+ with:
+ path: ~/.markdownlint-cache
+ key: ${{ runner.os }}-markdownlint-${{ hashFiles('**/*.md') }}
+ restore-keys: ${{ runner.os }}-markdownlint-
This will reduce the execution time of the workflow.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
- name: 🧐 Lint Markdown files | |
uses: DavidAnson/markdownlint-cli2-action@v16.0.0 | |
with: | |
globs: | | |
**/*.md | |
!CHANGELOG.md | |
- name: Cache Markdown lint results | |
uses: actions/cache@v2 | |
with: | |
path: ~/.markdownlint-cache | |
key: ${{ runner.os }}-markdownlint-${{ hashFiles('**/*.md') }} | |
restore-keys: ${{ runner.os }}-markdownlint- | |
- name: 🧐 Lint Markdown files | |
uses: DavidAnson/markdownlint-cli2-action@v16.0.0 | |
with: | |
globs: | | |
**/*.md | |
!CHANGELOG.md |
uses: shivammathur/setup-php@2.30.4 | ||
with: | ||
php-version: ${{ matrix.php-version }} | ||
extensions: none, ctype, dom, json, mbstring, phar, simplexml, tokenizer, xml, xmlwriter, phar | ||
ini-values: error_reporting=E_ALL | ||
coverage: none | ||
tools: phive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optimize PHP setup by specifying only necessary extensions.
- extensions: none, ctype, dom, json, mbstring, phar, simplexml, tokenizer, xml, xmlwriter, phar
+ extensions: ctype, json, mbstring
This will speed up the setup process by installing only the extensions that are actually needed.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
uses: shivammathur/setup-php@2.30.4 | |
with: | |
php-version: ${{ matrix.php-version }} | |
extensions: none, ctype, dom, json, mbstring, phar, simplexml, tokenizer, xml, xmlwriter, phar | |
ini-values: error_reporting=E_ALL | |
coverage: none | |
tools: phive | |
uses: shivammathur/setup-php@2.30.4 | |
with: | |
php-version: ${{ matrix.php-version }} | |
extensions: ctype, json, mbstring | |
ini-values: error_reporting=E_ALL | |
coverage: none | |
tools: phive |
Summary by CodeRabbit
New Features
Bug Fixes
.gitignore
to exclude.env
andcoverage.xml
.Documentation
README.md
with updated image tags and command snippets..github/CODE_OF_CONDUCT.md
with email and URL formatting.Refactor
composer.json
and added new ones for enhanced functionality.Chores
.yamllint.yaml
configuration..gitattributes
to exclude certain files from exports.