Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README #271

Merged
merged 1 commit into from
May 21, 2024
Merged

docs: update README #271

merged 1 commit into from
May 21, 2024

Conversation

lotyp
Copy link
Member

@lotyp lotyp commented May 21, 2024

Summary by CodeRabbit

  • Documentation

    • Updated README with detailed installation instructions, setup details, composer scripts, Git configurations, Makefile instructions, GitHub Actions integration, and contribution guidelines.
    • Added social links and resources.
  • New Features

    • Introduced custom rulesets for code style configuration.

@lotyp lotyp merged commit 9e5b58d into master May 21, 2024
22 checks passed
@lotyp lotyp deleted the docs/updates branch May 21, 2024 09:31
Copy link

coderabbitai bot commented May 21, 2024

Walkthrough

The README.md file for the wayofdev/cs-fixer-config package has been significantly enhanced. Key additions include detailed installation instructions, setup guidelines, composer scripts, Git configurations, Makefile usage, GitHub Actions integration, and contribution guidelines. Furthermore, new custom rulesets have been introduced, and social links and resources have been updated to provide comprehensive support and guidance for users.

Changes

File Change Summary
README.md Added information on custom rulesets, installation, setup, composer scripts, Git configurations, Makefile instructions, GitHub Actions integration, contribution guidelines, and updated social links/resources.
.../RuleSets/DefaultRuleset.php Introduced new custom ruleset: DefaultRuleset::class.
.../RuleSets/ExtendedPERSet.php Introduced new custom ruleset: ExtendedPERSet::class.

In lines of code, we find our way,
With rules and scripts, we shape the day.
From README's words to actions bright,
We craft and build with all our might.
So hop along, let's code with cheer,
For in this world, we persevere.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

Outside diff range and nitpick comments (2)
README.md (2)

Line range hint 120-139: Review the Makefile configuration for potential improvements in clarity and efficiency.

+ # This section defines the Makefile targets for linting PHP files using php-cs-fixer.
+ # It ensures that the necessary directories are created and that linting scripts are executed correctly.

Line range hint 147-236: Evaluate the GitHub Actions workflow for best practices and optimal configuration.

Consider optimizing the matrix strategy to include different PHP versions and dependency sets to ensure broader compatibility testing.

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 09f675f and 58826b6.
Files selected for processing (1)
  • README.md (11 hunks)
Additional Context Used
LanguageTool (1)
README.md (1)

Near line 294: This phrasing can be overused. Try elevating your writing with a more formal alternative.
Context: ...are open to all kinds of contributions. If you want to: * 🤔 [Suggest a feature](https://gith...

Additional comments not posted (3)
README.md (3)

30-30: Ensure the introduction clearly defines the scope and purpose of the repository.


111-111: Ensure the .build folder is correctly ignored in the project's .gitignore file.

Verification successful

The .build folder is correctly listed in the project's .gitignore file.

  • .gitignore contains the entry /.build/.
Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the .build folder is listed in the .gitignore file.

# Test: Search for the .build entry in the .gitignore file. Expect: Presence of the entry.
rg --type ignore $'/.build/'

Length of output: 58



Script:

#!/bin/bash
# Description: Verify the .build folder is listed in the .gitignore file.

# Test: Search for the .build entry in the .gitignore file. Expect: Presence of the entry.
rg '/.build/' .gitignore

Length of output: 33


98-98: Confirm that the new composer script commands are correctly implemented and function as intended.

Comment on lines +70 to +72
* Create PHP file and name it `.php-cs-fixer.dist.php` and place it inside root directory of project. It will be recognized by PHP CS Fixer automatically.

- Example contents of `.php-cs-fixer.dist.php` file:
* Example contents of `.php-cs-fixer.dist.php` file:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify the setup instructions for .php-cs-fixer.dist.php to ensure they are easy to follow for new users.

- * Create PHP file and name it `.php-cs-fixer.dist.php` and place it inside root directory of project. It will be recognized by PHP CS Fixer automatically.
+ * Create a PHP file named `.php-cs-fixer.dist.php` and place it in the root directory of your project. PHP CS Fixer will automatically recognize this configuration file.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
* Create PHP file and name it `.php-cs-fixer.dist.php` and place it inside root directory of project. It will be recognized by PHP CS Fixer automatically.
- Example contents of `.php-cs-fixer.dist.php` file:
* Example contents of `.php-cs-fixer.dist.php` file:
* Create a PHP file named `.php-cs-fixer.dist.php` and place it in the root directory of your project. PHP CS Fixer will automatically recognize this configuration file.
* Example contents of `.php-cs-fixer.dist.php` file:

Comment on lines 294 to +299
Thank you for considering contributing to the wayofdev community! We are open to all kinds of contributions. If you want to:

- 🤔 [Suggest a feature](https://github.com/wayofdev/php-cs-fixer-config/issues/new?assignees=&labels=type%3A+enhancement&projects=&template=2-feature-request.yml&title=%5BFeature%5D%3A+)
- 🐛 [Report an issue](https://github.com/wayofdev/php-cs-fixer-config/issues/new?assignees=&labels=type%3A+documentation%2Ctype%3A+maintenance&projects=&template=1-bug-report.yml&title=%5BBug%5D%3A+)
- 📖 [Improve documentation](https://github.com/wayofdev/php-cs-fixer-config/issues/new?assignees=&labels=type%3A+documentation%2Ctype%3A+maintenance&projects=&template=4-docs-bug-report.yml&title=%5BDocs%5D%3A+)
- 👨‍💻 Contribute to the code
* 🤔 [Suggest a feature](https://github.com/wayofdev/php-cs-fixer-config/issues/new?assignees=&labels=type%3A+enhancement&projects=&template=2-feature-request.yml&title=%5BFeature%5D%3A+)
* 🐛 [Report an issue](https://github.com/wayofdev/php-cs-fixer-config/issues/new?assignees=&labels=type%3A+documentation%2Ctype%3A+maintenance&projects=&template=1-bug-report.yml&title=%5BBug%5D%3A+)
* 📖 [Improve documentation](https://github.com/wayofdev/php-cs-fixer-config/issues/new?assignees=&labels=type%3A+documentation%2Ctype%3A+maintenance&projects=&template=4-docs-bug-report.yml&title=%5BDocs%5D%3A+)
* 👨‍💻 Contribute to the code
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elevate the formal tone of the contribution invitation.

- Thank you for considering contributing to the wayofdev community! We are open to all kinds of contributions. If you want to:
+ Thank you for considering a contribution to the wayofdev community! We welcome diverse contributions. Should you wish to:

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
Thank you for considering contributing to the wayofdev community! We are open to all kinds of contributions. If you want to:
- 🤔 [Suggest a feature](https://github.com/wayofdev/php-cs-fixer-config/issues/new?assignees=&labels=type%3A+enhancement&projects=&template=2-feature-request.yml&title=%5BFeature%5D%3A+)
- 🐛 [Report an issue](https://github.com/wayofdev/php-cs-fixer-config/issues/new?assignees=&labels=type%3A+documentation%2Ctype%3A+maintenance&projects=&template=1-bug-report.yml&title=%5BBug%5D%3A+)
- 📖 [Improve documentation](https://github.com/wayofdev/php-cs-fixer-config/issues/new?assignees=&labels=type%3A+documentation%2Ctype%3A+maintenance&projects=&template=4-docs-bug-report.yml&title=%5BDocs%5D%3A+)
- 👨‍💻 Contribute to the code
* 🤔 [Suggest a feature](https://github.com/wayofdev/php-cs-fixer-config/issues/new?assignees=&labels=type%3A+enhancement&projects=&template=2-feature-request.yml&title=%5BFeature%5D%3A+)
* 🐛 [Report an issue](https://github.com/wayofdev/php-cs-fixer-config/issues/new?assignees=&labels=type%3A+documentation%2Ctype%3A+maintenance&projects=&template=1-bug-report.yml&title=%5BBug%5D%3A+)
* 📖 [Improve documentation](https://github.com/wayofdev/php-cs-fixer-config/issues/new?assignees=&labels=type%3A+documentation%2Ctype%3A+maintenance&projects=&template=4-docs-bug-report.yml&title=%5BDocs%5D%3A+)
* 👨‍💻 Contribute to the code
Thank you for considering a contribution to the wayofdev community! We welcome diverse contributions. Should you wish to:
* 🤔 [Suggest a feature](https://github.com/wayofdev/php-cs-fixer-config/issues/new?assignees=&labels=type%3A+enhancement&projects=&template=2-feature-request.yml&title=%5BFeature%5D%3A+)
* 🐛 [Report an issue](https://github.com/wayofdev/php-cs-fixer-config/issues/new?assignees=&labels=type%3A+documentation%2Ctype%3A+maintenance&projects=&template=1-bug-report.yml&title=%5BBug%5D%3A+)
* 📖 [Improve documentation](https://github.com/wayofdev/php-cs-fixer-config/issues/new?assignees=&labels=type%3A+documentation%2Ctype%3A+maintenance&projects=&template=4-docs-bug-report.yml&title=%5BDocs%5D%3A+)
* 👨‍💻 Contribute to the code

Comment on lines +38 to +51
## 📜 Custom Rulesets

**```WayOfDev\PhpCsFixer\Config\RuleSets\DefaultRuleset::class```**

Based on **`@Symfony`** ruleset

* Used by [`@wayofdev`](https://github.com/wayofdev) organization

**`WayOfDev\PhpCsFixer\Config\RuleSets\ExtendedPERSet::class`**

Based on **`@PER-CS2.0`** ruleset

* Used by [`@buggregator`](https://github.com/buggregator) and [`@cycle`](http://github.com/cycle) organizations

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

The DefaultRuleset class was not found in the codebase, while the ExtendedPERSet class was located and its implementation details were partially retrieved.

  • DefaultRuleset class not found.
  • ExtendedPERSet class found in src/RuleSets/ExtendedPERSet.php.

Please verify the existence and correct implementation of the DefaultRuleset class or update the README.md accordingly.

Analysis chain

Verify the accuracy of the new custom rulesets and their descriptions.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the existence and correct implementation of the new custom rulesets.

# Test: Search for the ruleset classes in the codebase. Expect: Definitions of the classes.
rg --type php $'class DefaultRuleset' && rg --type php $'class ExtendedPERSet'

Length of output: 38



Script:

#!/bin/bash
# Description: Verify the existence and correct implementation of the new custom rulesets.

# Test: Search for the ruleset classes in the codebase. Expect: Definitions of the classes.
rg --type php 'class DefaultRuleset' || echo "DefaultRuleset class not found"
rg --type php 'class ExtendedPERSet' || echo "ExtendedPERSet class not found"

# If classes are found, display their file paths and a few lines of context around their definitions.
rg --type php 'class DefaultRuleset' -A 5 -B 5
rg --type php 'class ExtendedPERSet' -A 5 -B 5

Length of output: 1007

Comment on lines +319 to +324
* **Twitter:** Follow our organization [@wayofdev](https://twitter.com/intent/follow?screen_name=wayofdev) and the author [@wlotyp](https://twitter.com/intent/follow?screen_name=wlotyp).
* **Discord:** Join our community on [Discord](https://discord.gg/CE3TcCC5vr).

<p align="left">
<a href="https://discord.gg/CE3TcCC5vr" target="_blank"><img alt="Codecov" src="https://img.shields.io/discord/1228506758562058391?style=for-the-badge&logo=discord&labelColor=7289d9&logoColor=white&color=39456d"></a>
<a href="https://x.com/intent/follow?screen_name=wayofdev" target="_blank"><img alt="Follow on Twitter (X)" src="https://img.shields.io/badge/-Follow-black?style=for-the-badge&logo=X"></a>
<a href="https://discord.gg/CE3TcCC5vr" target="_blank"><img alt="Codecov" src="https://img.shields.io/discord/1228506758562058391?style=for-the-badge&logo=discord&labelColor=7289d9&logoColor=white&color=39456d"></a>
<a href="https://x.com/intent/follow?screen_name=wayofdev" target="_blank"><img alt="Follow on Twitter (X)" src="https://img.shields.io/badge/-Follow-black?style=for-the-badge&logo=X"></a>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

The Twitter link returned a 403 Forbidden status, which suggests there might be an issue with the link or access restrictions. The Discord link, however, redirected correctly to a valid invite link.

  • The Twitter link needs to be reviewed and potentially corrected.
  • The Discord link is functioning as expected.
Analysis chain

Confirm the accuracy and functionality of the social links and ensure they lead to the correct pages.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the functionality of social links.

# Test: Check if the URLs are reachable and correct.
curl -I https://twitter.com/intent/follow?screen_name=wayofdev && curl -I https://discord.gg/CE3TcCC5vr

Length of output: 2103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant