feat: class order

[lotyp]

Summary by CodeRabbit

• New Features

  • Enhanced configuration setup with a new constructor for initializing based on rules.

• Improvements

  • Updated default rule sets to include new properties and remove outdated ones.
  • Reordered configuration elements for better clarity and organization.

• Optimizations

  • Consolidated logic for initializing configuration properties.

These changes streamline configuration management and improve rule set clarity for a better user experience.

[coderabbitai]

Walkthrough

The recent updates streamline the ConfigBuilder class by consolidating its constructor logic and refining the initialization of Config objects. Additionally, the DefaultSet and ExtendedPERSet classes in the RuleSets directory have been modified to adjust the rules and order arrays, enhancing the configuration and rule-setting capabilities.

Changes

Files	Change Summary
src/ConfigBuilder.php	Updated ConfigBuilder class to include a new constructor with RuleSet parameter and removed a duplicate constructor.
src/RuleSets/DefaultSet.php	Modified rules() method to include 'construct' and remove 'destruct'.
src/RuleSets/ExtendedPERSet.php	Reordered elements in the order array, added new elements like case, construct, magic, and adjusted the order of existing elements.

In the land of code, where logic abides,
The ConfigBuilder now with one constructor rides.
DefaultSet constructs, while destruct steps aside,
ExtendedPERSet reorders, letting new rules preside.
With magic and order, our code does confide,
A rabbit's delight, in changes applied.
🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 745b27b and bd7be09.

Files selected for processing (3)

• src/ConfigBuilder.php (2 hunks)
• src/RuleSets/DefaultSet.php (2 hunks)
• src/RuleSets/ExtendedPERSet.php (1 hunks)

Additional comments not posted (3)

src/ConfigBuilder.php (1)

25-32: The refactoring of the constructor to initialize Config using RuleSet parameters simplifies the initialization process and enhances maintainability.

src/RuleSets/ExtendedPERSet.php (1)

99-119: The restructuring of the order array in the rules() method reflects new configuration priorities. Ensure this change aligns with the intended coding standards across projects.

Verification successful

---

The changes in the rules() method of ExtendedPERSet do not impact other parts of the codebase directly, as ExtendedPERSet is not used elsewhere. However, ensure that these changes align with the intended coding standards.

• DefaultSet includes method_public_abstract_static, which is part of the coding standards.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify the impact of the new order on existing projects.

# Test: Search for projects using the old order. Expect: Review if the new order affects them.
rg --type php $'constant_public_static|method_public_abstract_static'

Length of output: 239

---

---

Script:

#!/bin/bash
# Description: Verify the usage of DefaultSet and ExtendedPERSet in the codebase.

# Search for instances where DefaultSet is used.
rg --type php 'DefaultSet'

# Search for instances where ExtendedPERSet is used.
rg --type php 'ExtendedPERSet'

Length of output: 681

src/RuleSets/DefaultSet.php (1)

82-82: The inclusion of 'construct' in the order array aligns with the changes in other rule sets, ensuring consistency.