-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prefix all functions with back-slash #283
Conversation
WalkthroughThe primary change in this update involves modifying the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #283 +/- ##
=========================================
Coverage 56.37% 56.37%
Complexity 19 19
=========================================
Files 3 3
Lines 243 243
=========================================
Hits 137 137
Misses 106 106 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/RuleSets/ExtendedPERSet.php (1 hunks)
Additional Context Used
GitHub Check Runs (1)
codecov/patch failure (1)
src/RuleSets/ExtendedPERSet.php: [warning] 94-94: src/RuleSets/ExtendedPERSet.php#L94
Added line #L94 was not covered by tests
Additional comments not posted (1)
src/RuleSets/ExtendedPERSet.php (1)
94-94
: The change in scope from 'namespaced' to 'all' significantly broadens the impact of the ruleset. Ensure that this change is intentional and well-documented to avoid unexpected behavior in broader contexts.
@@ -91,7 +91,7 @@ | |||
NativeFunctionInvocationFixer::SET_INTERNAL, | |||
NativeFunctionInvocationFixer::SET_COMPILER_OPTIMIZED, | |||
], | |||
'scope' => 'namespaced', | |||
'scope' => 'all', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is not covered by tests. It's crucial to ensure that changes, especially those that affect the behavior of the system broadly, are well-tested.
Would you like me to help by generating unit tests for this change or should I open a GitHub issue to track this task?
Summary by CodeRabbit