Refactor HttpClient and add unit tests #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QU3B1M
reviewed
Oct 14, 2024
...mand-manager/src/main/java/com/wazuh/commandmanager/utils/httpclient/HttpRestClientDemo.java
Show resolved
Hide resolved
f-galland
approved these changes
Oct 14, 2024
AlexRuiz7
added a commit
that referenced
this pull request
Oct 14, 2024
* Add plugin-security.policy * Add dependencies and async http requests service class. * Make the plugin perform periodical http queries using placeholder scheduler and config classes * Adapt the plugin for POST requests to a local server * Small fixes * Switch to using HttpClient * Fix slf4j nop warnings * Fix test failing on forbidden api usage * Add json body * Use doPrivileged * Fix socket permission denied error * Make close() work again * Add lifecycle component back to jobscheduler placeholder class * Make AsyncRequestRepository a singleton * Remove unneeded dependencies * Add license and notice files * Fix forbiddenapis error * Skip checks dependency license checks and dependencies forbidden apis check * Refactor HttpClient and add unit tests (#102) * Refactor HttpClient and add unit tests * Add more JavaDocs * Fix Javadocs --------- Signed-off-by: Álex Ruiz <alejandro.ruiz.becerra@wazuh.com> Co-authored-by: Álex Ruiz <alejandro.ruiz.becerra@wazuh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the HttpClient for better readability and modularity, simplifying the code.
It also adds some unit tests.
Notes
PoolingAsyncClientConnectionManager. We may add the thread pool back.Issues Resolved
Closes #89