ensure JWS serializers only throw InvalidArgumentException #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Closing in favor of #513 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SerializerManager tries one serializer after another but expects the individual serializer only to throw InvalidArgumentException in ::unserialize - if any other Exception is thrown, unserialization (and JWS verification) fails directly.
The JSON serializers (global and flattened) try JSON-decoding using JsonConverter. The latter, however, throws a RuntimeException. Therefore, if a later serializer in the SerializerManager is applicable to the token, it's never reached.
This PR encapsulates the call to JsonEncoder and converts the exception to InvalidArgumentException.