chore: pr feedback

webbio · Jan 30, 2024 · 957280b · 957280b
1 parent 63e0f67
commit 957280b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/...gins/strapi-plugin-internal-links/admin/src/components/form/page-select/locale-select.tsx b/...gins/strapi-plugin-internal-links/admin/src/components/form/page-select/locale-select.tsx
@@ -33,8 +33,8 @@ export const LocaleSelect = ({ onChange, isDisabled, value, isLoadingValue }: Pr
 				value={value}
 				onChange={handleChange}
 			>
-				{(allLocales || []).map((l, index) => (
-					<SingleSelectOption value={l.code} key={index}>
+				{(allLocales || []).map((l) => (
+					<SingleSelectOption value={l.code} key={l.code}>
 						{l.code.toLocaleUpperCase()}
 					</SingleSelectOption>
 				))}

diff --git a/src/plugins/strapi-plugin-internal-links/admin/src/components/modal/index.tsx b/src/plugins/strapi-plugin-internal-links/admin/src/components/modal/index.tsx
@@ -16,7 +16,7 @@ interface IInternalLinkModalProps
 	attribute?: IInternalLinkAttribute;
 	toggleModal: () => void;
 	closeModal: () => void;
-	alwaysUseTitle?: boolean;
+	overwriteNoTitle?: boolean;
 }
 
 const InternalLinkModal = ({
@@ -25,7 +25,7 @@ const InternalLinkModal = ({
 	errors,
 	setErrors,
 	attribute,
-	alwaysUseTitle,
+	overwriteNoTitle,
 	toggleModal = () => {
 		console.warn('Modal toggle function not set');
 	},
@@ -37,7 +37,7 @@ const InternalLinkModal = ({
 	const { data: pluginConfig, isLoading: isLoadingConfig } = useGetConfig({});
 
 	const shouldShowTitle =
-		alwaysUseTitle ??
+		overwriteNoTitle ??
 		(!isLoadingConfig &&
 			(typeof attribute?.options?.noTitle === 'boolean'
 				? !attribute?.options?.noTitle