Fix pre-1.13 startup problem without breaking 1.13.1...

webbukkit · Aug 27, 2018 · e41b1f9 · e41b1f9
1 parent 7d72dc4
commit e41b1f9
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 5 deletions.
diff --git a/...r-113-1/src/main/java/org/dynmap/bukkit/helper/v113_1/BukkitVersionHelperSpigot113_1.java b/...r-113-1/src/main/java/org/dynmap/bukkit/helper/v113_1/BukkitVersionHelperSpigot113_1.java
@@ -47,6 +47,11 @@ public class BukkitVersionHelperSpigot113_1 extends BukkitVersionHelperCB {
     protected Class<?> datapalettearray;
     private Field blockid_field;
 
+    @Override
+    protected boolean isBlockIdNeeded() {
+        return false;
+    }
+
     public BukkitVersionHelperSpigot113_1() {
 		datapalettearray =  getNMSClass("[Lnet.minecraft.server.DataPaletteBlock;");
     	blockid_field = getPrivateField(craftchunksnapshot, new String[] { "blockids" }, datapalettearray);

diff --git a/...-helper-113/src/main/java/org/dynmap/bukkit/helper/v113/BukkitVersionHelperSpigot113.java b/...-helper-113/src/main/java/org/dynmap/bukkit/helper/v113/BukkitVersionHelperSpigot113.java
@@ -46,6 +46,11 @@ public class BukkitVersionHelperSpigot113 extends BukkitVersionHelperCB {
     protected Class<?> datapalettearray;
     private Field blockid_field;
 
+    @Override
+    protected boolean isBlockIdNeeded() {
+        return false;
+    }
+
     public BukkitVersionHelperSpigot113() {
 		datapalettearray =  getNMSClass("[Lnet.minecraft.server.DataPaletteBlock;");
     	blockid_field = getPrivateField(craftchunksnapshot, new String[] { "blockids" }, datapalettearray);

diff --git a/bukkit-helper/src/main/java/org/dynmap/bukkit/helper/BukkitVersionHelper.java b/bukkit-helper/src/main/java/org/dynmap/bukkit/helper/BukkitVersionHelper.java
@@ -22,7 +22,9 @@ public abstract class BukkitVersionHelper {
 
     public static DynmapBlockState[] stateByID;
 
-    protected boolean blockidsneeded = true;
+    protected boolean isBlockIdNeeded() {
+        return true;
+    }
 
     protected BukkitVersionHelper() {
 

diff --git a/bukkit-helper/src/main/java/org/dynmap/bukkit/helper/BukkitVersionHelperCB.java b/bukkit-helper/src/main/java/org/dynmap/bukkit/helper/BukkitVersionHelperCB.java
@@ -69,14 +69,11 @@ protected void loadNMS() {
         nmsblock = getNMSClass("net.minecraft.server.Block");
         nmsblockarray = getNMSClass("[Lnet.minecraft.server.Block;");
         nmsmaterial = getNMSClass("net.minecraft.server.Material");
-        Log.info("blockidsneeded=" + blockidsneeded);
-        if (blockidsneeded) {   // Not needed for 1.13+
+        if (isBlockIdNeeded()) {   // Not needed for 1.13+
             blockbyid = getFieldNoFail(nmsblock, new String[] { "byId" }, nmsblockarray);
             if (blockbyid == null) {
                 blockbyidfunc = getMethod(nmsblock, new String[] { "getById", "e" }, new Class[] { int.class });
-                Log.info("blockbyidfunc found = " + (blockbyidfunc != null));
             }
-            Log.info("blockbyid found = " + (blockbyid != null));
         }
         material = getPrivateField(nmsblock, new String[] { "material" }, nmsmaterial);