-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for fabric-1.21.1 #4148
base: v3.0
Are you sure you want to change the base?
Conversation
I've been waiting for this for a month or so now. Any idea when this will be merged? |
+1, would like to use this for my server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to update the version range in the readme table.
What about these errors during the build?
unknown invokedynamic bsm: java/lang/runtime/SwitchBootstraps/typeSwitch(Ljava/lang/invoke/MethodHandles$Lookup;Ljava/lang/String;Ljava/lang/invoke/MethodType;[Ljava/lang/Object;)Ljava/lang/invoke/CallSite; (tag=6 iif=false)
unknown invokedynamic bsm: java/lang/runtime/SwitchBootstraps/typeSwitch(Ljava/lang/invoke/MethodHandles$Lookup;Ljava/lang/String;Ljava/lang/invoke/MethodType;[Ljava/lang/Object;)Ljava/lang/invoke/CallSite; (tag=6 iif=false)
unknown invokedynamic bsm: java/lang/runtime/SwitchBootstraps/typeSwitch(Ljava/lang/invoke/MethodHandles$Lookup;Ljava/lang/String;Ljava/lang/invoke/MethodType;[Ljava/lang/Object;)Ljava/lang/invoke/CallSite; (tag=6 iif=false)
unknown invokedynamic bsm: java/lang/runtime/SwitchBootstraps/typeSwitch(Ljava/lang/invoke/MethodHandles$Lookup;Ljava/lang/String;Ljava/lang/invoke/MethodType;[Ljava/lang/Object;)Ljava/lang/invoke/CallSite; (tag=6 iif=false)
✅ It works perfectly fine for me.
For everyone who doesn't want to build the jar yourself:
- Download Dynmap-3.7-beta-7-fabric-1.21.1.jar.zip
- Extract the jar from the zip
- Put it into you mods folder
- (Re-)Start your server
//implementation 'org.xerial:sqlite-jdbc:3.30.1' | ||
shadow group: 'org.xerial', name: 'sqlite-jdbc', version: '3.30.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please explain why you changed this to shadow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a mistake on my part. It is a local modification to include sqlite support on fabirc for some of our local servers. I forgot to remove that when preparing the PR.
I did not even notice these. :-( I'm back from travelling abroad and will respond quicker going forward. |
I'd have to google/chatgpt them myself. ChatGPT wasnt particularily helpful on first try. In the source code it would look like this: switch (obj) {
case String s -> System.out.println("It's a string: " + s);
case Integer i -> System.out.println("It's an integer: " + i);
case Double d -> System.out.println("It's a double: " + d);
case null -> System.out.println("It's null");
default -> System.out.println("It's some other type");
} Unfortunately I'm not sure if this is part of the replacement source code or if mixin is trying to add a new case into there. |
No changes except the usual 1.21 -> 1.21.1 modification.
Lightly tested, no issues observed.