Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for fabric-1.21.1 #4148

Open
wants to merge 1 commit into
base: v3.0
Choose a base branch
from

Conversation

petersv5
Copy link

No changes except the usual 1.21 -> 1.21.1 modification.
Lightly tested, no issues observed.

@Ryderbike1
Copy link

I've been waiting for this for a month or so now. Any idea when this will be merged?

@RealSourceOfficial
Copy link

+1, would like to use this for my server.

Copy link

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the version range in the readme table.


What about these errors during the build?

unknown invokedynamic bsm: java/lang/runtime/SwitchBootstraps/typeSwitch(Ljava/lang/invoke/MethodHandles$Lookup;Ljava/lang/String;Ljava/lang/invoke/MethodType;[Ljava/lang/Object;)Ljava/lang/invoke/CallSite; (tag=6 iif=false)
unknown invokedynamic bsm: java/lang/runtime/SwitchBootstraps/typeSwitch(Ljava/lang/invoke/MethodHandles$Lookup;Ljava/lang/String;Ljava/lang/invoke/MethodType;[Ljava/lang/Object;)Ljava/lang/invoke/CallSite; (tag=6 iif=false)
unknown invokedynamic bsm: java/lang/runtime/SwitchBootstraps/typeSwitch(Ljava/lang/invoke/MethodHandles$Lookup;Ljava/lang/String;Ljava/lang/invoke/MethodType;[Ljava/lang/Object;)Ljava/lang/invoke/CallSite; (tag=6 iif=false)
unknown invokedynamic bsm: java/lang/runtime/SwitchBootstraps/typeSwitch(Ljava/lang/invoke/MethodHandles$Lookup;Ljava/lang/String;Ljava/lang/invoke/MethodType;[Ljava/lang/Object;)Ljava/lang/invoke/CallSite; (tag=6 iif=false)

✅ It works perfectly fine for me.

For everyone who doesn't want to build the jar yourself:

Comment on lines +40 to +41
//implementation 'org.xerial:sqlite-jdbc:3.30.1'
shadow group: 'org.xerial', name: 'sqlite-jdbc', version: '3.30.1'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain why you changed this to shadow?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a mistake on my part. It is a local modification to include sqlite support on fabirc for some of our local servers. I forgot to remove that when preparing the PR.

@petersv5
Copy link
Author

Don't forget to update the version range in the readme table.

What about these errors during the build?

unknown invokedynamic bsm: java/lang/runtime/SwitchBootstraps/typeSwitch(Ljava/lang/invoke/MethodHandles$Lookup;Ljava/lang/String;Ljava/lang/invoke/MethodType;[Ljava/lang/Object;)Ljava/lang/invoke/CallSite; (tag=6 iif=false)
unknown invokedynamic bsm: java/lang/runtime/SwitchBootstraps/typeSwitch(Ljava/lang/invoke/MethodHandles$Lookup;Ljava/lang/String;Ljava/lang/invoke/MethodType;[Ljava/lang/Object;)Ljava/lang/invoke/CallSite; (tag=6 iif=false)
unknown invokedynamic bsm: java/lang/runtime/SwitchBootstraps/typeSwitch(Ljava/lang/invoke/MethodHandles$Lookup;Ljava/lang/String;Ljava/lang/invoke/MethodType;[Ljava/lang/Object;)Ljava/lang/invoke/CallSite; (tag=6 iif=false)
unknown invokedynamic bsm: java/lang/runtime/SwitchBootstraps/typeSwitch(Ljava/lang/invoke/MethodHandles$Lookup;Ljava/lang/String;Ljava/lang/invoke/MethodType;[Ljava/lang/Object;)Ljava/lang/invoke/CallSite; (tag=6 iif=false)

I did not even notice these. :-(
They are outside of my level of understanding for the mixin system, which is what I assume these messages are from. Any idea how to track them down? As we have not seen any issues since the switch in mid August we have not really looked much into Dynmap build logs since then.

I'm back from travelling abroad and will respond quicker going forward.

@ST-DDT
Copy link

ST-DDT commented Oct 22, 2024

They are outside of my level of understanding for the mixin system, which is what I assume these messages are from. Any idea how to track them down?

I'd have to google/chatgpt them myself.

ChatGPT wasnt particularily helpful on first try.
It points to updating java to 17+ and checking for mixin updates/bug reports.

In the source code it would look like this:

switch (obj) {
            case String s -> System.out.println("It's a string: " + s);
            case Integer i -> System.out.println("It's an integer: " + i);
            case Double d -> System.out.println("It's a double: " + d);
            case null -> System.out.println("It's null");
            default -> System.out.println("It's some other type");
}

Unfortunately I'm not sure if this is part of the replacement source code or if mixin is trying to add a new case into there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants