Copy img in html tag #496
Closed
Copy img in html tag #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
commit: |
|
Damn, I created the PR first and then saw that a PR for this already exists: #493 :p I think this PR is the really really lightweight version (+/- 5 changed lines) of that one |
|
Thanks @MartenBE! Except that it also contains the dependency updates. We can just merge that one first once its ready, or fix up this one separately. Up to you, happy to merge either way. |
|
You can merge the dependancies now, then this PR. I've merged it together. |
|
Cherry picked in 358f162 |
|
Thanks for the fix @MartenBE! Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use
<img ... />tags so I can rescale them usingwidth,heightorstyle="width: ...; height: ..."attributes. Although the live server shows everything fine, the static website missed all the images declared in this way. Upon further inspection, the regex to detect images only detects markdown images and not HTML<img>tags. This PR should enable both.