Skip to content

Commit

Permalink
Merge pull request #17 from wednesday-solutions/feat/restructuring
Browse files Browse the repository at this point in the history
feat - restructing of module
  • Loading branch information
himanshu-wedensday authored Mar 11, 2024
2 parents c5d5439 + 151acd9 commit 65cc5aa
Show file tree
Hide file tree
Showing 30 changed files with 76 additions and 59 deletions.
10 changes: 0 additions & 10 deletions .env

This file was deleted.

18 changes: 12 additions & 6 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
venv/
__pycache__/
*/__pycache__/
*/*/__pycache__/
python-fastapi/
.vscode/
# Local Environment
env
venv

# Config file
.env

*__pycache__*

# Temp files
tmp/
temp/
5 changes: 2 additions & 3 deletions alembic/versions/45f7c66353f4_initialize_all_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,8 @@

from alembic import op
import sqlalchemy as sa
import models
from models import users # noqa

from app import models # noqa
from app.models import users # noqa

# revision identifiers, used by Alembic.
revision: str = "45f7c66353f4"
Expand Down
File renamed without changes.
10 changes: 5 additions & 5 deletions app.py → app/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@
from fastapi.exceptions import RequestValidationError
from fastapi.middleware.cors import CORSMiddleware
from fastapi.responses import JSONResponse
from routes.users import user
from app.routes import user
from fastapi_pagination import add_pagination
from middlewares.rate_limiter_middleware import RateLimitMiddleware
from middlewares.request_id_injection import RequestIdInjection
from app.middlewares.rate_limiter_middleware import RateLimitMiddleware
from app.middlewares.request_id_injection import RequestIdInjection
from pybreaker import CircuitBreakerError
from dependencies import circuit_breaker
from utils.slack_notification_utils import send_slack_message
from app.utils.slack_notification_utils import send_slack_message
import traceback
from middlewares.request_id_injection import request_id_contextvar
from app.middlewares.request_id_injection import request_id_contextvar

# Initializing the swagger docs
app = FastAPI(
Expand Down
11 changes: 11 additions & 0 deletions app/config/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
from .config import get_secret_key
from .db import create_local_session, engine
from .redis_config import get_redis_pool


__all__ = [
"get_secret_key",
"create_local_session",
"engine",
"get_redis_pool",
]
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion constants/jwt_utils.py → app/constants/jwt_utils.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from fastapi import HTTPException
import jwt
import datetime
from config.config import get_secret_key
from app.config.config import get_secret_key


def create_access_token(data: dict):
Expand Down
File renamed without changes.
3 changes: 3 additions & 0 deletions app/daos/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
from .users import get_user, list_users, create_user, login

__all__ = ["get_user", "list_users", "create_user", "login"]
14 changes: 6 additions & 8 deletions daos/users.py → app/daos/users.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,15 @@
from aioredis import Redis
from fastapi import HTTPException
from sqlalchemy.orm import Session
from constants import jwt_utils
from constants.messages.users import user_messages as messages
from models.users import User
from schemas.users import CreateUser
from schemas.users import Login
from schemas.users import UserOutResponse
from app.constants import jwt_utils
from app.constants.messages.users import user_messages as messages
from app.models import User
from app.schemas import CreateUser, UserOutResponse, Login
from werkzeug.security import check_password_hash
from fastapi_pagination.ext.sqlalchemy import paginate
from sqlalchemy import select
from utils import redis_utils
from utils.user_utils import check_existing_field, responseFormatter
from app.utils import redis_utils
from app.utils.user_utils import check_existing_field, responseFormatter


def get_user(user_id: int, dbSession: Session):
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
13 changes: 13 additions & 0 deletions app/models/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# import glob
# from os.path import basename
# from os.path import dirname
# from os.path import isfile
# from os.path import join

# modules = glob.glob(join(dirname(__file__), "*.py"))

# __all__ = [basename(f)[:-3] for f in modules if isfile(f) and not f.endswith("__init__.py")]

from .users import User

__all__ = ["User"]
2 changes: 1 addition & 1 deletion models/users.py → app/models/users.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from werkzeug.security import generate_password_hash
from sqlalchemy import event

from config.db import engine
from app.config.db import engine

Base = declarative_base()

Expand Down
3 changes: 3 additions & 0 deletions app/routes/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
from .users import user

__all__ = ["user"]
24 changes: 12 additions & 12 deletions routes/users.py → app/routes/users.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,20 @@
from fastapi import Depends
from sqlalchemy.orm import Session
from fastapi_pagination import Page
from config.db import create_local_session
from daos.users import create_user as create_user_dao
from daos.users import get_user as get_user_dao
from daos.users import list_users as list_users_dao
from daos.users import login as signin
from models.users import User
from schemas.users import CreateUser
from schemas.users import UserOutResponse
from schemas.users import Login
from utils.redis_utils import get_redis
from utils.user_utils import get_current_user
from app.config.db import create_local_session
from app.daos import (
create_user as create_user_dao,
get_user as get_user_dao,
list_users as list_users_dao,
login as signin,
)
from app.models import User
from app.schemas import CreateUser, UserOutResponse, Login
from app.utils.redis_utils import get_redis
from app.utils.user_utils import get_current_user
from typing import Annotated
from fastapi.security import HTTPBearer
from middlewares.request_id_injection import request_id_contextvar
from app.middlewares.request_id_injection import request_id_contextvar

user = APIRouter()

Expand Down
3 changes: 3 additions & 0 deletions app/schemas/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
from .users import CreateUser, Login, UserOutResponse

__all__ = ["CreateUser", "Login", "UserOutResponse"]
2 changes: 1 addition & 1 deletion schemas/users.py → app/schemas/users.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import re

from constants.messages.users import user_messages as messages
from app.constants.messages.users import user_messages as messages
from fastapi import HTTPException
from pydantic import BaseModel
from pydantic import validator
Expand Down
File renamed without changes.
Empty file added app/utils/__init__.py
Empty file.
2 changes: 1 addition & 1 deletion utils/redis_utils.py → app/utils/redis_utils.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from config.redis_config import get_redis_pool
from app.config.redis_config import get_redis_pool


async def get_redis():
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion utils/user_utils.py → app/utils/user_utils.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from fastapi import HTTPException
from sqlalchemy.orm import Session
from fastapi import Request, HTTPException
from constants import jwt_utils
from app.constants import jwt_utils
from fastapi import HTTPException


Expand Down
9 changes: 0 additions & 9 deletions models/__init__.py

This file was deleted.

2 changes: 1 addition & 1 deletion scripts/local_server.sh
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# Run migrations and start server
alembic upgrade head && uvicorn app:app --host 0.0.0.0 --port 8000
alembic upgrade head && uvicorn app.app:app --host 0.0.0.0 --port 8000

0 comments on commit 65cc5aa

Please sign in to comment.