Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught KilledByHttp2ThreadManager exceptions #156

Closed
edsko opened this issue May 29, 2024 · 4 comments
Closed

Uncaught KilledByHttp2ThreadManager exceptions #156

edsko opened this issue May 29, 2024 · 4 comments
Assignees
Labels
bug Something isn't working priority: medium Should be done before the library can be considered complete

Comments

@edsko
Copy link
Collaborator

edsko commented May 29, 2024

When running the test suite, we're getting output such as

Uncaught exception in ThreadId 9542 (unknown label): KilledByHttp2ThreadManager (Just ConnectionIsClosed)

(coming from uncaughtExceptionHandler in test-grapesy/Main.hs). I previously tried to fix this (kazu-yamamoto/http2#92) but something changed somewhere and now we're still seeing these exceptions occassionally. I think it doesn't infer with the functionality of the library, but it's confusing output nonetheless.

@edsko edsko added bug Something isn't working priority: medium Should be done before the library can be considered complete labels May 29, 2024
@edsko
Copy link
Collaborator Author

edsko commented Jun 20, 2024

@FinleyMcIlwaine The threads created by grapesy are labelled, but the threads created by http2 are not. I have a WIP branch at https://github.com/edsko/http2/tree/edsko/thread-labelling to address this. I'm not sure what the status of it is, it for sure needs rebasing, and it might be incomplete.

@edsko
Copy link
Collaborator Author

edsko commented Jun 26, 2024

Possibly related: #123 (comment) (I thought I fixed these though by adding more general functions upstream to http2 - mentioning it just in case.)

@FinleyMcIlwaine
Copy link
Collaborator

I am not seeing these messages on main anymore after #183

@edsko
Copy link
Collaborator Author

edsko commented Jul 25, 2024

We're not seeing this anymore (as of 492c351). Closing.

@edsko edsko closed this as completed Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: medium Should be done before the library can be considered complete
Projects
None yet
Development

No branches or pull requests

2 participants