Detect final element #155
Merged
Detect final element #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: We should grep the codebase for mentions of 114. |
edsko
force-pushed
the
edsko/end-of-stream
branch
2 times, most recently
from
c5b5c86
to
10eb799
Compare
edsko
force-pushed
the
edsko/end-of-stream
branch
2 times, most recently
from
dc1e9c0
to
9303873
Compare
|
Turns out this is somewhat non-determistic. We need to relax the tests, I think. |
|
I don't really understand where the non-determinism is coming from however, needs further investigation. |
|
This happens when the final HTTP frame is split across two TCP packets. |
edsko
force-pushed
the
edsko/end-of-stream
branch
from
9303873
to
21e20a4
Compare
|
Depends on kazu-yamamoto/http-semantics#2 and kazu-yamamoto/http2#120 . |
edsko
force-pushed
the
edsko/end-of-stream
branch
2 times, most recently
from
083124d
to
a1c7023
Compare
Closes #114.
edsko
force-pushed
the
edsko/end-of-stream
branch
from
a1c7023
to
b91e1a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #114.
Depends on kazu-yamamoto/http-semantics#1 and kazu-yamamoto/http2#116 .