Fixed Asterisk 14+ event formatting issues #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added limit to explode commands as any returned data containing additional : was being exploded to additional array elements and lost. ie. "Output: Something: Value" would only return "Something" Removed conditions that only non-blank lines are returned in data. This was making returned data differ from what AGI actually returns and didn't match Asterisk 13- results. Remove condition that data is only collected and returned if first Output: line is non-blank. This was causing any command issues that returned a blank line on line 1 to return no data. ie. "Action: Command Command: parking show default" would return no data since line 1 is always blank.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added limit to explode commands as any returned data containing additional : was being exploded to additional array elements and lost. ie. "Output: Something: Value" would only return "Something"
Removed conditions that only non-blank lines are returned in data. This was making returned data differ from what AGI actually returns and didn't match Asterisk 13- results.
Remove condition that data is only collected and returned if first Output: line is non-blank. This was causing any commands issued that returned a blank line on line 1 to return no data. ie.
"Action: Command
Command: parking show default"
would return no data since line 1 is always blank.