Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(shortcodes): support URLs for image source #280

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

welpo
Copy link
Owner

@welpo welpo commented Feb 15, 2024

Summary

Modifies all image shortcodes to allow remote sources. Before, using a link would prefix it with the base_url.

Changes

  • Added checks to differentiate between remote URLs and local image paths.
  • Ensured all changes are backward compatible, maintaining existing functionality while introducing these improvements.

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@welpo welpo added the enhancement New feature or request label Feb 15, 2024
@welpo welpo force-pushed the feat/remote-url-img-shortcodes branch 3 times, most recently from 7414f9c to ef9d913 Compare February 15, 2024 23:47
@welpo welpo force-pushed the feat/remote-url-img-shortcodes branch from ef9d913 to a71419b Compare February 15, 2024 23:48
@welpo welpo merged commit ed845ea into main Feb 15, 2024
2 checks passed
@welpo welpo deleted the feat/remote-url-img-shortcodes branch February 15, 2024 23:49
Smtbook pushed a commit to Smtbook/zola-theme-tabi that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant