Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use post.date when no post.updated entry exists #355

Merged
merged 3 commits into from
Jul 14, 2024
Merged

Conversation

sam9032
Copy link
Contributor

@sam9032 sam9032 commented Jul 13, 2024

Summary

Without this fix, there is no date if you set post_listing_date = "updated" and the post has no updated date.

image

Related issue

#326

#330

Changes

If the post doesn't has an updated entry, the creation date is used:

image

Accessibility

Screenshots

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@sam9032 sam9032 requested a review from welpo as a code owner July 13, 2024 21:36
Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit 1a49b7f
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/6693e1a1b83fef00088363ba
😎 Deploy Preview https://deploy-preview-355--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@welpo
Copy link
Owner

welpo commented Jul 13, 2024

Great idea! I think it should be in the docs. Could you please update the Mastering tabi (English) post and the comments in config.toml and theme.toml?

@welpo welpo merged commit 5db006a into welpo:main Jul 14, 2024
6 of 7 checks passed
@welpo
Copy link
Owner

welpo commented Jul 14, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants