Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(header): render feed links based on config #358

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

welpo
Copy link
Owner

@welpo welpo commented Jul 24, 2024

Summary

This PR fixes a bug where feed links were being rendered in the header even when feeds were disabled. It introduces a more flexible and robust solution for handling feed links in the header template.

Related issue

Fixes #352.

Changes

  • Modified header.html to conditionally render feed links
  • Added support for multiple feed types (Atom and RSS)
  • Improved code to use config.feed_filenames for Zola 0.19.x and newer, falling back to config.feed_filename for older versions

Accessibility

Unaffected.

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@welpo welpo added the bug Something isn't working label Jul 24, 2024
Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit 57e92b4
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/66a13a69e86a8e0008c2d71e
😎 Deploy Preview https://deploy-preview-358--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@welpo welpo merged commit 24896a5 into main Jul 24, 2024
7 checks passed
@welpo welpo deleted the fix/feed-header-links branch July 24, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardcoded feed path on header
1 participant