🐛 fix: improve dark mode and OS theme handling #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tabi-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
welpo
force-pushed
the
fix/improve-dark-mode-handling
branch
from
bea9f15
to
f311ede
Compare
- Ensure dark theme applies when explicitly set or by OS preference. - Fixes issues with admonition styling, skins, and social icons (footer). Resolves #379.
welpo
force-pushed
the
fix/improve-dark-mode-handling
branch
from
f311ede
to
a9f6c23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure dark theme applies when explicitly set or by OS preference. Solves styling inconsistencies.
Related issue
Resolves #379. Bug introduced in #357. Discussion started in #378.
Changes
Consistently applies styling for dark/light mode, regardless of OS theme, default tabi theme, and theme switcher status (enabled/disabled).
Specifically:
default_themewas unset inconfig.toml, and (3) the OS was set to dark theme.Accessibility
The changes improve accessibility by ensuring proper contrast in dark mode for various elements.
Screenshots
Issue with social icons:
Issue with admonition styling:
Type of change
Checklist
theme.tomlwith a sane default for the featureconfig.tomlcommentstheme.tomlcomments