Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feat: add force_text_direction shortcode #414

Merged
merged 1 commit into from
Oct 18, 2024
Merged

✨ feat: add force_text_direction shortcode #414

merged 1 commit into from
Oct 18, 2024

Conversation

welpo
Copy link
Owner

@welpo welpo commented Oct 18, 2024

Summary

Introduces a new shortcode force_text_direction that allows fine-grained control over text direction within specific content blocks.

Related issue

Related: #412 and #411

Changes

  • Introduced new force_text_direction shortcode
  • The shortcode overrides both the global force_codeblock_ltr setting and the document's overall direction
  • Accepts "ltr" (left-to-right) or "rtl" (right-to-left) as direction parameter

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@welpo welpo added the enhancement New feature or request label Oct 18, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 18, 2024 •
edited
Loading

✅ Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit 8d2c24d
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/6712927340cdac00080648d8
😎 Deploy Preview https://deploy-preview-414--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@welpo
✨ feat: add force_text_direction shortcode
8d2c24d 
- Introduce new `force_text_direction` shortcode
- Overrides global `force_codeblock_ltr` setting and document direction
- Accepts "ltr" or "rtl" as direction parameter
@welpo welpo force-pushed the feat/force-text-direction-shortcode branch from efe52f5 to 8d2c24d Compare October 18, 2024 16:53
@welpo welpo merged commit 07d7171 into main Oct 18, 2024
5 of 7 checks passed
@welpo welpo deleted the feat/force-text-direction-shortcode branch October 18, 2024 16:53
welpo added a commit that referenced this pull request Oct 18, 2024
@welpo
✨ feat: add force_text_direction shortcode (#414)
c9f8d27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@welpo