Merge pull request #342 from werf/fix-jobs-not-failing-on-errors

fix: Jobs not failing on errors
werf · Mar 21, 2024 · 1837be1 · 1837be1
2 parents b4b4fe4 + 823b8ac
commit 1837be1
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/pkg/trackers/dyntracker/statestore/readiness_task_state.go b/pkg/trackers/dyntracker/statestore/readiness_task_state.go
@@ -212,8 +212,6 @@ func initReadinessTaskStateFailureConditions(failMode multitrack.FailMode, total
 	})
 
 	if failMode != multitrack.IgnoreAndContinueDeployProcess {
-		maxErrors := lo.Max([]int{totalAllowFailuresCount + 1})
-
 		failureConditions = append(failureConditions, func(taskState *ReadinessTaskState) bool {
 			var totalErrsCount int
 			lo.Must0(domigraph.BFS(taskState.resourceStatesTree, util.ResourceID(taskState.name, taskState.namespace, taskState.groupVersionKind), func(id string) bool {
@@ -231,7 +229,7 @@ func initReadinessTaskStateFailureConditions(failMode multitrack.FailMode, total
 				return false
 			}))
 
-			return totalErrsCount > maxErrors
+			return totalErrsCount > totalAllowFailuresCount
 		})
 	}