Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TYPO3 13 LTS Support #122

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@ jobs:
typo3-version: '^12.4'
- php-version: '8.3'
typo3-version: '^12.4'
- php-version: '8.2'
typo3-version: '^13.4'
- php-version: '8.3'
typo3-version: '^13.4'
steps:
- uses: actions/checkout@v3

Expand All @@ -103,7 +107,6 @@ jobs:
- name: Install dependencies with expected TYPO3 version
run: |-
composer require --no-interaction --prefer-dist --no-progress "typo3/cms-backend:${{ matrix.typo3-version }}" "typo3/cms-core:${{ matrix.typo3-version }}" "typo3/cms-extbase:${{ matrix.typo3-version }}" "typo3/cms-frontend:${{ matrix.typo3-version }}" "typo3/cms-fluid-styled-content:${{ matrix.typo3-version }}"
./vendor/bin/codecept build

- name: Code Quality (by PHPStan)
run: ./vendor/bin/phpstan analyse
Expand All @@ -125,6 +128,12 @@ jobs:
- php-version: '8.3'
typo3-version: '^12.4'
db-version: '8'
- php-version: '8.2'
typo3-version: '^13.4'
db-version: '8'
- php-version: '8.3'
typo3-version: '^13.4'
db-version: '8'
steps:
- uses: actions/checkout@v3

Expand Down Expand Up @@ -158,15 +167,3 @@ jobs:
export typo3DatabaseUsername="root"
export typo3DatabasePassword="root"
./vendor/bin/phpunit

tests-acceptance:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3

- uses: cachix/install-nix-action@v24
with:
nix_path: nixpkgs=channel:nixos-unstable

- name: Run Acceptance Tests
run: nix-shell --run project-test-acceptance
3 changes: 3 additions & 0 deletions .php-cs-fixer.dist.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
$finder = (new PhpCsFixer\Finder())
->ignoreVCSIgnored(true)
->in(realpath(__DIR__))
->notPath([
'Classes/Domain/Import/EntityMapper/CustomAnnotationExtractor.php',
]);
;

return (new \PhpCsFixer\Config())
Expand Down
2 changes: 1 addition & 1 deletion Classes/Command/ImportConfigurationCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ protected function configure(): void
);
}

protected function execute(InputInterface $input, OutputInterface $output)
protected function execute(InputInterface $input, OutputInterface $output): int
{
Bootstrap::initializeBackendAuthentication();

Expand Down
7 changes: 6 additions & 1 deletion Classes/Controller/Backend/AbstractController.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@ protected function initializeView(): void

protected function htmlResponse(?string $html = null): ResponseInterface
{
return parent::htmlResponse($html ?? $this->moduleTemplate->render());
$action = sprintf(
'%s/%s',
str_replace('\\', '/', $this->request->getControllerName()),
ucfirst($this->request->getControllerActionName()),
);
return parent::htmlResponse($html ?? $this->moduleTemplate->render($action));
}
}
Loading
Loading