-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #326: Add new regex to catch MUMmer v4 version information #335
Conversation
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
==========================================
+ Coverage 76.32% 76.47% +0.15%
==========================================
Files 52 52
Lines 3404 3414 +10
==========================================
+ Hits 2598 2611 +13
+ Misses 806 803 -3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small note at l.140. (also make Exception catching specific for PermissionError
and FileNotFoundError
when can't find exacutable - do we need to do this for the other tools, also?)
Keep this PR in-sync with PR #335
Re: the The other options for |
THe case which would trigger this should be caught earlier on with `os.access(<file>, os.X_OK)`
Adds new code to catch version information for new version of MUMmer.
Feedback may be needed on the specific error types used.
Note: this will likely require some new tests (to-be-written).
Closes #326.
Type of change
Action Checklist
pyani
repository under your own account (please allow write access for repository maintainers)CONTRIBUTING.md
)pytest -v
non-passing code will not be mergedorigin/master
flake8
andblack
before submissionPull requests
section in thepyani
repository