Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add tests and github actions workflow #12

Merged
merged 1 commit into from
Oct 25, 2024
Merged

ci: add tests and github actions workflow #12

merged 1 commit into from
Oct 25, 2024

Conversation

iisakkirotko
Copy link
Collaborator

test_tabbed_viewer_close requires #9 to pass

@iisakkirotko Graphite App
Copy link
Collaborator Author

iisakkirotko commented Oct 21, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @iisakkirotko and the rest of your teammates on Graphite Graphite

@iisakkirotko iisakkirotko force-pushed the 10-21-ci_add_tests_and_github_actions_workflow branch 6 times, most recently from 73d5e13 to bc66b84 Compare October 21, 2024 13:45
@iisakkirotko iisakkirotko marked this pull request as ready for review October 21, 2024 13:45
This was referenced Oct 21, 2024
Merged
Merged
@iisakkirotko
ci: add tests and github actions workflow
6454b33 
`test_tabbed_viewer_close` requires #9 to pass
@iisakkirotko iisakkirotko force-pushed the 10-21-ci_add_tests_and_github_actions_workflow branch from bc66b84 to 6454b33 Compare October 21, 2024 15:09
maartenbreddels
maartenbreddels reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@maartenbreddels maartenbreddels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do a seperate build job, so we have the build artifact (wheel)?
Also feel free to merge this first, and do this in a separate PR

@iisakkirotko Graphite App
Copy link
Collaborator Author

iisakkirotko commented Oct 25, 2024 •
edited
Loading

Merge activity

  • Oct 25, 6:39 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 25, 6:39 AM EDT: A user merged this pull request with Graphite.

@iisakkirotko iisakkirotko merged commit 1f3faf3 into master Oct 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maartenbreddels maartenbreddels maartenbreddels left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iisakkirotko @maartenbreddels