Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable navigation to hashes #814

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

iisakkirotko
Copy link
Collaborator

Previously this was not officially supported, and would only work when moving within a page, or when initially loading a page with SSG enabled.

Copy link
Collaborator Author

iisakkirotko commented Oct 14, 2024

@maartenbreddels
Copy link
Contributor

If I go:
http://localhost:8765/documentation/advanced/enterprise/oauth
and click on say 'Configuring Fief' i navigate to it, but the hash does not change in the address bar (80% of the time).
If I then click it again, the hash does change.
I scroll up a bit, and click the https link with the hash to
http://localhost:8765/documentation/getting_started/deploying/self-hosted#https
That works seems to work, as well as navigating back, but it might be good to check after fixes.
I wonder if the problem is related to having 2 state attributes?

@iisakkirotko iisakkirotko force-pushed the 10-14-chore_remove_extra_checks_for_hash branch from 541b4bc to 916e8cf Compare October 22, 2024 15:13
@iisakkirotko iisakkirotko force-pushed the 10-14-feat_enable_navigation_to_hashes branch from 172f50c to 53b21e8 Compare October 22, 2024 15:13
Copy link
Collaborator Author

iisakkirotko commented Oct 24, 2024

Merge activity

  • Oct 24, 11:04 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 24, 11:07 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 24, 11:08 AM EDT: A user merged this pull request with Graphite.

@iisakkirotko iisakkirotko changed the base branch from 10-14-chore_remove_extra_checks_for_hash to graphite-base/814 October 24, 2024 15:05
@iisakkirotko iisakkirotko changed the base branch from graphite-base/814 to master October 24, 2024 15:05
Previously this was not officially supported, and would only work when moving within a page, or when initially loading a page with SSG enabled.
@iisakkirotko iisakkirotko force-pushed the 10-14-feat_enable_navigation_to_hashes branch from 53b21e8 to 105c87f Compare October 24, 2024 15:06
@iisakkirotko iisakkirotko merged commit ab09c58 into master Oct 24, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants