Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: do not allow reactive to be used as boolean #846

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: do not allow reactive to be used as boolean #846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions solara/toestand.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,28 @@ def __init__(self, merge: Callable = merge_state):
self.listeners: Dict[str, Set[Tuple[Callable[[T], None], Optional[ContextManager]]]] = defaultdict(set)
self.listeners2: Dict[str, Set[Tuple[Callable[[T, T], None], Optional[ContextManager]]]] = defaultdict(set)

# make sure all boolean operations give type errors
def __bool__(self):
raise TypeError("Reactive vars are not allowed in boolean expressions, did you want to use .value?")

def __eq__(self, other):
raise TypeError("Reactive vars are not allowed in boolean expressions, did you want to use .value?")

def __ne__(self, other):
raise TypeError("Reactive vars are not allowed in boolean expressions, did you want to use .value?")

def __lt__(self, other):
raise TypeError("Reactive vars are not allowed in boolean expressions, did you want to use .value?")

def __le__(self, other):
raise TypeError("Reactive vars are not allowed in boolean expressions, did you want to use .value?")

def __gt__(self, other):
raise TypeError("Reactive vars are not allowed in boolean expressions, did you want to use .value?")

def __ge__(self, other):
raise TypeError("Reactive vars are not allowed in boolean expressions, did you want to use .value?")

@property
def lock(self):
raise NotImplementedError
Expand Down
Loading