WFCORE-7004: use custom parser over default #6206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michpetrov Would it be possible to add a test case for the use case described in the Jira? |
|
@yersan you mean a test for the parser? Do we have something like that already? I'd rather not have to mock up a subsystem from scratch. |
michpetrov
force-pushed
the
wfcore-7004
branch
from
5da7b61
to
3dc2df7
Compare
|
@yersan added the test |
yersan
approved these changes
Oct 14, 2024
yersan
added
the
ready-for-merge
|
Thanks @michpetrov for the fix and adding a test case, CC @pferraro since you are now refactorizing this class |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: WFCORE-7004
The default
parseElementmethod should ideally never be accessed after this fix but in case it is I assume it's better to throw an exception rather then having one thrown by the XML reader because that makes it look like something's wrong with the XML file.