Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgresql auth add bcrypt pw hashing #68

Merged
merged 7 commits into from
Aug 15, 2023

Conversation

asbjorn
Copy link
Contributor

@asbjorn asbjorn commented Aug 14, 2023

I really don't like storing passwords as plain text in db :)
Also added a section in the README.md file to help users create the SQL tables and also creating hashed versions of the MQTT client passwords.

@wind-c
Copy link
Owner

wind-c commented Aug 15, 2023

I'm a big proponent of hashing passwords.

@wind-c
Copy link
Owner

wind-c commented Aug 15, 2023

There are several problems with your PR:

  1. Build failed
  2. There should also be go's bcrypt snippet in the README file
  3. Have redundant "if err! = nil"

Run go build ./...
go: downloading golang.org/x/crypto v0.0.0-20220622213112-05595931fe9d
go: updates to go.mod needed; to update it:
go mod tidy
Error: Process completed with exit code 1.

@asbjorn
Copy link
Contributor Author

asbjorn commented Aug 15, 2023

Hi @wind-c!

Thanks for the feedback - it seems that I forgot the go mod tidy and the redundant iferr checks. There should also be a section in the README file. Also added a link from bcrypt to its corresponding Wikipedia article.

@wind-c
Copy link
Owner

wind-c commented Aug 15, 2023

good job

@wind-c wind-c merged commit b9cde6d into wind-c:main Aug 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants