Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WINDUPRULE-1014] Add rules for several removed APIs #1010

Closed
wants to merge 8 commits into from

Conversation

jmle
Copy link
Contributor

@jmle jmle commented Jul 25, 2023

See Jira ticket.

Merge this first.

@PhilipCattanach
Copy link
Contributor

@jmle - Can you split the first rule into two rules as
java.lang.ThreadGroup.allowThreadSuspension({*})"
Has nothing to do with finalize which is what the issue title and message is referring to.
Also is 1 SP enough, we have allocated 3 SP in the finalize-deprecation ruleset which was the first OpenJDK21 ruleset implemented

@PhilipCattanach
Copy link
Contributor

@jmle the final rule is about the removal of java.lang.Compiler and javax.management.remote.rmi.RMIIIOPServerImpl classes
But the issue title and description is referring to finalization. Please split that rule into 2 rules, one per class and explicitly call of the class names as you have with java.lang.ThreadGroup.allowThreadSuspension

@jmle jmle closed this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants