Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WINDUPRULE-1014] Add rules for several removed APIs #1015

Merged
merged 9 commits into from
Jul 31, 2023
Merged

[WINDUPRULE-1014] Add rules for several removed APIs #1015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
de56e11
[WINDUPRULE-1012] Add rules for the future deprecation of the finaliz…
jmle Jul 24, 2023
0a0f670
[WINDUPRULE-1014] Add rules for several removed methods and classes
jmle Jul 25, 2023
79d0aa6
[WINDUPRULE-1012] Rename folder
jmle Jul 25, 2023
9cc6263
[WINDUPRULE-1014] Fix conflicts
jmle Jul 25, 2023
08fb3e1
Merge branch 'master' into WINDUPRULE-1014
jmle Jul 25, 2023
a3f6c21
[WINDUPRULE-1014] Separate rule
jmle Jul 27, 2023
c872249
Change story points
jmle Jul 28, 2023
c757c4d
Merge branch 'master' into WINDUPRULE-1014
PhilipCattanach Jul 28, 2023
04d21c4
[WINDUPRULE-1014] Fix rule message and divide it in two
jmle Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 75 additions & 0 deletions rules/rules-reviewed/openjdk21/openjdk17/removed-apis.windup.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
<?xml version="1.0"?>
<ruleset xmlns="http://windup.jboss.org/schema/jboss-ruleset" id="removed-apis-openjdk21"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://windup.jboss.org/schema/jboss-ruleset http://windup.jboss.org/schema/jboss-ruleset/windup-jboss-ruleset.xsd">
<metadata>
<description>
This ruleset provides analysis regarding removed APIs in OpenJDK 18 to 21.
</description>
<dependencies>
<addon id="org.jboss.windup.rules,windup-rules-java,3.0.0.Final" />
</dependencies>
<targetTechnology id="openjdk" versionRange="[18,)"/>
</metadata>
<rules>
<rule id="removed-apis-00000">
<when>
<or>
<javaclass references="java.awt.color.ICC_Profile.finalize()">
<location>METHOD_CALL</location>
</javaclass>
<javaclass references="java.awt.image.ColorModel.finalize()">
<location>METHOD_CALL</location>
</javaclass>
<javaclass references="java.awt.image.IndexColorModel.finalize()">
<location>METHOD_CALL</location>
</javaclass>
</or>
</when>
<perform>
<hint title="These finalization methods have been removed" effort="3" category-id="mandatory">
<message>
This finalization method has been removed between JDK 18 and 21 and must be removed from the code.
</message>
</hint>
</perform>
</rule>
<rule id="removed-apis-00005">
<when>
<javaclass references="java.lang.ThreadGroup.allowThreadSuspension({*})">
<location>METHOD_CALL</location>
</javaclass>
</when>
<perform>
<hint title="Method java.lang.ThreadGroup.allowThreadSuspension() has been removed" effort="1" category-id="mandatory">
<message>
The `java.lang.ThreadGroup.allowThreadSuspension` method has been removed and cannot be used anymore.
</message>
</hint>
</perform>
</rule>
<rule id="removed-apis-00010">
<when>
<javaclass references="java.lang.Compiler"/>
</when>
<perform>
<hint title="Method java.lang.Compiler has been removed" effort="3" category-id="mandatory">
<message>
The `java.lang.Compiler` method has been removed and cannot be used anymore.
</message>
</hint>
</perform>
</rule>
<rule id="removed-apis-00015">
<when>
<javaclass references="javax.management.remote.rmi.RMIIIOPServerImpl"/>
</when>
<perform>
<hint title="javax.management.remote.rmi.RMIIIOPServerImpl" effort="3" category-id="mandatory">
<message>
The `javax.management.remote.rmi.RMIIIOPServerImpl` method has been removed and cannot be used anymore.
</message>
</hint>
</perform>
</rule>
</rules>
</ruleset>
23 changes: 23 additions & 0 deletions ...ewed/openjdk21/openjdk17/tests/data/finalization-deprecation/FinalizationDeprecation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import javax.imageio.stream.FileImageOutputStream;
import java.io.File;

public class FinalizationDeprecation extends Object {

public static void main(String[] args) {
FinalizationDeprecation o1 = new FinalizationDeprecation();
o1.finalize();

Runtime runtime = Runtime.getRuntime();
runtime.runFinalization();

System.runFinalization();

FileImageOutputStream stream = new FileImageOutputStream(new File("hey"));
stream.finalize();
}

@Override
protected void finalize() throws Throwable {
super.finalize();
}
}
23 changes: 23 additions & 0 deletions rules/rules-reviewed/openjdk21/openjdk17/tests/data/removed-apis/RemovedApis.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import java.awt.color.ICC_Profile;
import java.awt.image.ColorModel;
import java.awt.image.IndexColorModel;
import java.lang.Compiler;
import javax.management.remote.rmi.RMIIIOPServerImpl;

public class FinalizationDeprecation extends Object {

public static void main(String[] args) {
ICC_Profile profile = ICC_Profile.getInstance(1);
profile.finalize();

ColorModel colorModel = ColorModel.getRGBdefault();
colorModel.finalize();

IndexColorModel indexColorModel = IndexColorModel.getRGBdefault();
indexColorModel.finalize();

ThreadGroup threadGroup = new ThreadGroup();
threadGroup.allowThreadSuspension();
}

}
2 changes: 1 addition & 1 deletion rules/rules-reviewed/openjdk21/openjdk17/tests/finalization-deprecation.windup.test.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<ruletest id="finalization-deprecation-test"
xmlns="http://windup.jboss.org/schema/jboss-ruleset"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://windup.jboss.org/schema/jboss-ruleset http://windup.jboss.org/schema/jboss-ruleset/windup-jboss-ruleset.xsd">
<testDataPath>data</testDataPath>
<testDataPath>data/finalization-deprecation</testDataPath>
<rulePath>../finalization-deprecation.windup.xml</rulePath>
<ruleset>
<rules>
Expand Down
59 changes: 59 additions & 0 deletions rules/rules-reviewed/openjdk21/openjdk17/tests/removed-apis.windup.test.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
<?xml version="1.0"?>
<ruletest id="removed-apis-openjdk21-test"
xmlns="http://windup.jboss.org/schema/jboss-ruleset"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://windup.jboss.org/schema/jboss-ruleset http://windup.jboss.org/schema/jboss-ruleset/windup-jboss-ruleset.xsd">
<testDataPath>data/removed-apis</testDataPath>
<rulePath>../removed-apis.windup.xml</rulePath>
<ruleset>
<rules>
<rule id="removed-apis-test-00000">
<when>
<not>
<iterable-filter size="3">
<hint-exists message="This finalization method has been removed between JDK 18 and 21 and must be*" />
</iterable-filter>
</not>
</when>
<perform>
<fail message="removed-apis-test-00000 - the hint was not found"/>
</perform>
</rule>
<rule id="removed-apis-test-00005">
<when>
<not>
<iterable-filter size="1">
<hint-exists message="The `java.lang.ThreadGroup.allowThreadSuspension` method has been removed and cannot be used anymore." />
</iterable-filter>
</not>
</when>
<perform>
<fail message="removed-apis-test-00005 - the hint was not found"/>
</perform>
</rule>
<rule id="removed-apis-test-00010">
<when>
<not>
<iterable-filter size="1">
<hint-exists message="The `java.lang.Compiler` method has been removed and cannot be used anymore." />
</iterable-filter>
</not>
</when>
<perform>
<fail message="removed-apis-test-00010 - the hint was not found"/>
</perform>
</rule>
<rule id="removed-apis-test-00015">
<when>
<not>
<iterable-filter size="1">
<hint-exists message="The `javax.management.remote.rmi.RMIIIOPServerImpl` method has been removed and cannot be used anymore." />
</iterable-filter>
</not>
</when>
<perform>
<fail message="removed-apis-test-00015 - the hint was not found"/>
</perform>
</rule>
</rules>
</ruleset>
</ruletest>