Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing declaration of direct dependencies #242

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

stekycz
Copy link
Contributor

@stekycz stekycz commented Aug 15, 2024

triple-beam and winston-transport are directly required by the code but they are missing in package.json file. It may work in environments where hoisting of node_modules is allowed but using PNPM in strict mode (especially with prod dependencies only) causes fatal errors on not found modules.

@DABH DABH merged commit d87a7e8 into winstonjs:master Aug 15, 2024
3 checks passed
@DABH
Copy link
Contributor

DABH commented Aug 15, 2024

Thanks, this was released as v2.7.1

@stekycz stekycz deleted the patch-1 branch August 16, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants