Profiler.done doesn't respect defaultMeta.

[q42jaap]

Please tell us about your environment:

• winston version?
  • winston@2
  • winston@3.2.1
• node -v outputs:
  v8.10.0
• Operating System? (Windows, macOS, or Linux)
  Linux
• Language? (all | TypeScript X.X | ES6/7 | ES5 | Dart)
  all

What is the problem?

The following code:

const winston = require('winston');

const logger = winston.createLogger({
  defaultMeta: {metaProp: 'metaValue'},
  transports: [
    new winston.transports.Console(),
  ],
});

logger.info('with meta');

const timer = logger.startTimer();
timer.done({message: 'without meta'});

Logs this to the console:

{"message":"with meta","level":"info","prop":"value"}
{"message":"without meta","level":"info","durationMs":1}

What do you expect to happen instead?

I would expect the Profiler.done function to add the defaultMeta to the log entry.

[wlopez-enkoding]

Were you able to solve the problem?

[q42jaap]

We never solved it.

[wlopez-enkoding]

We never solved it.

I noticed that this information is only printed out when the type of the output is error. It's not displayed when are just info.

[linqFR]

I noticed same issue on winston@3.3.3

[maverick1872]

Closing as this issue is being consolidated into #2029

[wvhulle]

This still seems to be an issue.

[wbt]

Is it an issue in v3.7.1? The fixes for the consolidated issue got reverted after that as they inadvertently broke some things, and neither @maverick1872 nor anyone else has gotten around to fixing that breakage yet as far as I'm aware.