Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An option to exclude spat from message #2323

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hosseinzoda
Copy link

A single option added to exclude splat from message by default.

@wbt wbt requested a review from maverick1872 July 11, 2023 20:43
@maverick1872
Copy link
Member

@hosseinzoda This would constitute a breaking change to the current functionality. Is there a specific reason you're opting to disable by default rather than taking the backwards compatible approach of enabling by default and allowing consumers to explicitly disable?

@hosseinzoda
Copy link
Author

@maverick1872 Thanks for the reply, If I'm not missing something, The value being false will make it backward compatible, As by default spat is not excluded from the message.

Copy link
Member

@maverick1872 maverick1872 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad on my previous comment; misread the conditional. Implementation looks good to me but would really appreciate it if we could get tests added also to proof it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants