Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save a reference to console methods in console transport #2498

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Save a reference to console methods in console transport #2498

merged 2 commits into from
Aug 8, 2024

Conversation

neilenns
Copy link
Contributor

@neilenns neilenns commented Aug 8, 2024

Fixes #2497

  • Save local references to console.log, console.warn, and console.error
  • Use those references instead of the original methods when logging

@Jimbly could you please give this a try and see if it fixes your circular reference issue? I could never get a circular reference, but I did get other errors that no longer happen with this change and logging seems to work fine.

DABH
DABH approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM up to comment - but also want @Jimbly to test ideally :)

lib/winston/transports/console.js Outdated Show resolved Hide resolved
@DABH
Copy link
Contributor

DABH commented Aug 8, 2024

Will wait a day or so to see if @Jimbly can give us the 👍 on this one but it does look like it's in the spirit of the fix that was being discussed... thanks!

@DABH DABH mentioned this pull request Aug 8, 2024
Closed
Jimbly
Jimbly approved these changes Aug 8, 2024
View reviewed changes
Copy link

@Jimbly Jimbly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

lib/winston/transports/console.js Outdated Show resolved Hide resolved
@neilenns neilenns requested review from Jimbly and DABH August 8, 2024 19:20
@DABH
Copy link
Contributor

DABH commented Aug 8, 2024

Will merge and ship this as a patch release (I think that feels appropriate), please feel free to try out the new version (to be released imminently) and lmk what you think. Thanks again for the contributions!

@DABH DABH merged commit e82752f into winstonjs:master Aug 8, 2024
4 checks passed
@DABH DABH mentioned this pull request Aug 13, 2024
Closed
@MRdevX MRdevX mentioned this pull request Aug 29, 2024
Open
@saileshbro saileshbro mentioned this pull request Aug 30, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Aug 30, 2024
Open
@Hamza-Slama Hamza-Slama mentioned this pull request Aug 30, 2024
Open
@Pavel-Durov Pavel-Durov mentioned this pull request Aug 30, 2024
Closed
@fanibahar fanibahar mentioned this pull request Aug 30, 2024
Open
@nc-minh nc-minh mentioned this pull request Aug 30, 2024
Open
@drnachio drnachio mentioned this pull request Aug 30, 2024
Open
@jgrevich jgrevich mentioned this pull request Aug 30, 2024
Open
@FlorentinTh FlorentinTh mentioned this pull request Aug 30, 2024
Open
@mechanicalpete mechanicalpete mentioned this pull request Aug 30, 2024
Merged
@FlorentinTh FlorentinTh mentioned this pull request Aug 30, 2024
Open
@paladinmansouri paladinmansouri mentioned this pull request Aug 30, 2024
Open
@NickyMartinez NickyMartinez mentioned this pull request Aug 30, 2024
Open
@debarghyab debarghyab mentioned this pull request Aug 30, 2024
Open
@Dmitry-White Dmitry-White mentioned this pull request Aug 30, 2024
Open
@2lambda123 2lambda123 mentioned this pull request Aug 30, 2024
Merged
@nejidevelops nejidevelops mentioned this pull request Aug 30, 2024
Open
@Dmitry-White Dmitry-White mentioned this pull request Sep 28, 2024
Open
@phoebeyusnyk phoebeyusnyk mentioned this pull request Sep 29, 2024
Open
This was referenced Sep 29, 2024
Open
Open
This was referenced Sep 29, 2024
Open
Open
@WontonSam WontonSam mentioned this pull request Sep 30, 2024
Open
@tahmid198 tahmid198 mentioned this pull request Sep 30, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Oct 1, 2024
Open
@BuckinghamAJ BuckinghamAJ mentioned this pull request Oct 2, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Oct 2, 2024
Open
@larbikhounti larbikhounti mentioned this pull request Oct 3, 2024
Open
This was referenced Oct 3, 2024
Open
Open
Open
@AnushaSalian AnushaSalian mentioned this pull request Oct 8, 2024
Open
@supriza supriza mentioned this pull request Oct 26, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Oct 27, 2024
Open
@snykyzach snykyzach mentioned this pull request Oct 27, 2024
Open
@rish2497 rish2497 mentioned this pull request Oct 27, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Oct 27, 2024
Open
@fanibahar fanibahar mentioned this pull request Oct 29, 2024
Open
@m-heyda m-heyda mentioned this pull request Oct 31, 2024
Open
@nc-minh nc-minh mentioned this pull request Oct 31, 2024
Open
@paladinmansouri paladinmansouri mentioned this pull request Oct 31, 2024
Open
@BenjaminHoegh BenjaminHoegh mentioned this pull request Oct 31, 2024
Closed
@larbikhounti larbikhounti mentioned this pull request Nov 1, 2024
Open
This was referenced Nov 1, 2024
Open
Open
@drnachio drnachio mentioned this pull request Nov 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DABH DABH DABH approved these changes

@Jimbly Jimbly Awaiting requested review from Jimbly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: forceConsole may cause circular reference if console.log is redirected to Winston
3 participants
@neilenns @DABH @Jimbly