Update docs for PSR-12 coding style guide #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
LukeTowers
reviewed
Aug 26, 2024
| ``` | ||
|
|
||
| ##### - We disallow using a `use` case for a class that exists in the same namespace as the current class |
There was a problem hiding this comment.
Do we want to rule either way here? I can see an argument for allowing it (so that it's easier to refactor / relocate classes) as well as the argument for disallowing it (technically it's unnecessary).
There was a problem hiding this comment.
Subjective, but I like to have as few use cases as possible. On the other hand, have all the classes defined as use cases at the top does give a sort of "index" as to what classes are being used in the file. So, I dunno, maybe all @wintercms/maintainers can chime in :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: wintercms/winter#1188