WIP: twig node migration #1102
Draft
WIP: twig node migration #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjauvin
added
help wanted
|
@jaxwilko can you merge develop into wip-laravel-11 so that this diff is useful? |
|
@LukeTowers i did, don't think github realised tho |
# Conflicts: # composer.json
|
@mjauvin what's left to resolve here? |
Our custom nodes still need to be fixed for twig 4.x |
|
Do they work with the latest Twig 3 @mjauvin? If so then we can wait to migrate to Twig 4 for v1.3 of Winter |
Yes, they finally fixed their shit in twig 3.12.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Twig 3.9.0, Nodes using "echo" or "print" are deprecated and should use "yield":
ref. twigphp/Twig@0990f81