-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce PSR-12 and organise imports on Winter CMS core files #1188
Draft
bennothommo
wants to merge
12
commits into
develop
Choose a base branch
from
fix/psr-12
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Aug 23, 2024
-
Enforce PSR-12 on Winter CMS core files
This commit changes the PHP code sniffer to use PSR-12 rules, as that ruleset will pick up a lot of the code style issues being flagged in PRs recently. In order to set the baseline, all current core files have been reformatted to fit the ruleset.
Configuration menu - View commit details
-
Copy full SHA for e7ebbb2 - Browse repository at this point
Copy the full SHA e7ebbb2View commit details -
Additional code style fixes to improve future diffs and IDE support
- Convert all aliases to qualified class names (mainly facades) - Reorder imports alphabetically - Ensure last item in array has a trailing comma - Strip out unused imports
Configuration menu - View commit details
-
Copy full SHA for 66bd3f3 - Browse repository at this point
Copy the full SHA 66bd3f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbf6019 - Browse repository at this point
Copy the full SHA dbf6019View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce14395 - Browse repository at this point
Copy the full SHA ce14395View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87171ca - Browse repository at this point
Copy the full SHA 87171caView commit details -
Configuration menu - View commit details
-
Copy full SHA for e23c0b2 - Browse repository at this point
Copy the full SHA e23c0b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2ffbe9 - Browse repository at this point
Copy the full SHA b2ffbe9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b72f82 - Browse repository at this point
Copy the full SHA 7b72f82View commit details
Commits on Sep 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2643609 - Browse repository at this point
Copy the full SHA 2643609View commit details -
Split off Winter CMS code style ruleset to its own XML
This will allow us to use the ruleset in plugins as well
Configuration menu - View commit details
-
Copy full SHA for 52a824f - Browse repository at this point
Copy the full SHA 52a824fView commit details -
Remove partial from exclusion list
With new ruleset, it now passes
Configuration menu - View commit details
-
Copy full SHA for a6b814b - Browse repository at this point
Copy the full SHA a6b814bView commit details -
This command will allow developers to check code style against the Winter CMS code style rules in both the core and installed plugins.
Configuration menu - View commit details
-
Copy full SHA for 236c459 - Browse repository at this point
Copy the full SHA 236c459View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.