fix: Rename docker workdir to /opt/githubapp, aligning with Helm chart

[spoonman01]

No description provided.

[claude]

PR Review

Summary: Renames the Docker image workdir/copy path from /opt/github-app to /opt/githubapp to align with the Helm chart. Small, focused, and correct.

Correctness — I verified the alignment claim against the Helm chart:

• helm/githubapp/templates/statefulset.yaml:79 mounts the persistent volume at mountPath: /opt/githubapp/storage.
• Before this change the container WORKDIR was /opt/github-app (hyphenated), so the app's working directory did not match the mount point. Since the Wire SDK's CryptoBox/storage directory is resolved relative to the working directory, crypto state written to ./storage would have landed at /opt/github-app/storage — outside the mounted PVC, so it wouldn't persist across pod restarts.

So this isn't purely cosmetic — it makes the storage volume mount actually effective. Nice catch. The ENTRYPOINT ["java", "-jar", "github-app.jar"] still resolves correctly, since the jar is copied into the new /opt/githubapp/ and WORKDIR points there.

Minor observations (non-blocking, out of scope)

• docker-compose.yml:23 mounts a named volume at github-app:/app, which matches neither the build stage nor the runtime workdir (/opt/githubapp). Looks like a leftover that provides no storage persistence for local runs — worth cleaning up in a follow-up.
• Consider having the app read the storage location from an explicit env var / config value rather than relying on the CWD, so a Dockerfile/Helm mismatch like the one this PR fixes can't silently recur.

Tests — No tests apply to a Dockerfile path change; nothing needed here. A quick docker build + confirming the container starts and writes to /opt/githubapp/storage is sufficient sanity check.

LGTM.