You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nice milestone 🎉 The change itself is correct and minimal — version = "0.1.0" in build.gradle.kts:14. A few notes, mostly about things around the bump rather than the line itself.
Verified: no build/runtime breakage
shadowJar pins archiveFileName.set("github-app.jar") (build.gradle.kts), so the artifact name is independent of version. The DockerfileCOPY --from=build-env /app/build/libs/github-app.jar path stays valid. 👍
A grep over src/main/kotlin finds no runtime reads of the project version, so nothing else shifts behaviourally.
Version drift with the Helm chart
helm/githubapp/Chart.yaml still carries:
version: 0.0.1appVersion: "0.0.1"
This matters beyond cosmetics, because appVersion is load-bearing in two places:
helm/githubapp/templates/_helpers.tpl:40 — the app.kubernetes.io/version label
helm/githubapp/values.yaml defines no image.tag, so any install that does not pass values-prod.yaml (which pins tag: "sha-9efe83d") resolves to quay.io/wire/github-app:0.0.1 — a tag that is never published, since .github/workflows/staging.yml only pushes type=sha,format=short. That is a pre-existing latent issue rather than something this PR introduces, but the bump makes the drift concrete and it is cheap to address here.
Suggestions, in order of preference:
Bump Chart.yamlappVersion to "0.1.0" (and the chart version per your chart-release policy) in this PR, so app version and deployment metadata stay in lockstep.
Separately, consider setting an explicit default image.tag in values.yaml (or making the chart fail fast when it is unset) so the Chart.AppVersion fallback cannot silently resolve to a non-existent tag.
Release hygiene for a 0.0.1 to 0.1.0 bump
git tag returns nothing and there is no CHANGELOG.md. For a version bump framed as a release, it would be useful to:
tag v0.1.0 on merge, and/or cut a GitHub Release;
record what changed since 0.0.1 — otherwise the version number carries no information for anyone reading it later.
If you would rather not maintain this by hand: the version now lives in two files with no automation keeping them aligned. A small CI check, or deriving the Helm appVersion from the Gradle version at package time, would prevent the next drift.
Version is not observable at runtime
Because images are sha-tagged, there is currently no way to ask a running instance which app version it is. Exposing the Gradle version through a /version or health payload (e.g. a generated build-info resource or a JAR manifest attribute) would make 0.1.0 useful operationally. Out of scope for this PR — flagging it as the natural follow-up to adopting semantic versioning.
Not applicable here
Security: no attack surface touched; no dependency, credential, or endpoint changes.
Performance: none.
Test coverage: no test changes needed — nothing asserts on the version string, and adding such an assertion would not be valuable. I did not run the Gradle build, since a version literal change cannot affect compilation and the artifact name is hardcoded as noted above.
Overall: happy to see this land. The only thing I would genuinely ask for before merge is the Chart.yamlappVersion alignment, since that value feeds a real image tag.
Note: this repo has no CLAUDE.md, so I reviewed against the conventions visible in the existing Gradle/Helm/CI setup. If you would like reviews to follow specific house rules, adding one would help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump app version to 0.1.0 🎉