fix: starting conversation with user without clients (WPB-18997) - #5190
fix: starting conversation with user without clients (WPB-18997)#5190sbakhtiarov wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5190 +/- ##
========================================
Coverage 52.26% 52.27%
========================================
Files 668 668
Lines 23913 23916 +3
Branches 3943 3944 +1
========================================
+ Hits 12499 12502 +3
Misses 10253 10253
Partials 1161 1161
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Shouldn't we show an alert telling current user, that user X needs to open Wire or log in again first ? |
| state = state.copy(isConversationStarted = isOneToOneConversationCreated) | ||
| val readiness = checkOneToOneConversationIsReady(userId) | ||
| if (readiness is CheckOneToOneConversationIsReadyUseCase.Result.Failure) { | ||
| appLogger.w("Failed to check one-to-one conversation readiness: ${readiness.coreFailure}") |
There was a problem hiding this comment.
so what happens if there is a failure? isConversationStarted is false by default, so when there is a failure here and user clicks the button then the app tries to create a new conversation, right? will that work?
4 participants
https://wearezeta.atlassian.net/browse/WPB-18997
https://wearezeta.atlassian.net/browse/WPB-18997
What's new in this PR?
Issues
Android client allows creating 1:1 conversation with the user without clients (e.g. never logged in wire app).
Solutions
Using new use case introduced in wireapp/kalium#4404 to resolve one-on-one conversations correctly.