Skip to content

feat: Display viewer only banner on shared drive and conversation (WPB-26394) - #5193

Open
ohassine wants to merge 9 commits into
developfrom
Display-viewer-only-banner-on-Shared-drive-and-conversation
Open

feat: Display viewer only banner on shared drive and conversation (WPB-26394)#5193
ohassine wants to merge 9 commits into
developfrom
Display-viewer-only-banner-on-Shared-drive-and-conversation

Conversation

@ohassine

@ohassine ohassine commented Aug 19, 2026

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-26394


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description:

Display viewer-only banner on Shared drive and conversation
In shared drive, if user closes the banner, it won't show up again.

Screenshot_20260819_174120

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…y-banner-on-Shared-drive-and-conversation

# Conflicts:
#	core/ui-common/src/main/res/drawable/ic_close.xml
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellsViewModelFactory.kt
@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.86957% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.46%. Comparing base (18b1028) to head (f211cdb).

⚠️ Current head f211cdb differs from pull request most recent head e31edc6

Please upload reports for the commit e31edc6 to get more accurate results.

Files with missing lines Patch % Lines
...com/wire/android/feature/cells/ui/CellViewModel.kt 70.00% 3 Missing and 3 partials ⚠️
...kotlin/com/wire/android/datastore/UserDataStore.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5193   +/-   ##
========================================
  Coverage    52.45%   52.46%           
========================================
  Files          739      739           
  Lines        25702    25724   +22     
  Branches      4215     4219    +4     
========================================
+ Hits         13481    13495   +14     
- Misses       10933    10938    +5     
- Partials      1288     1291    +3     
Files with missing lines Coverage Δ
.../ui/home/messagecomposer/EnabledMessageComposer.kt 0.00% <ø> (ø)
...om/wire/android/datastore/UserDataStoreProvider.kt 0.00% <ø> (ø)
...kotlin/com/wire/android/datastore/UserDataStore.kt 0.00% <0.00%> (ø)
...com/wire/android/feature/cells/ui/CellViewModel.kt 48.19% <70.00%> (+1.31%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18b1028...e31edc6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Test Results

168 tests   - 2 452   168 ✅  - 2 452   17s ⏱️ - 1m 8s
 31 suites  -   302     0 💤 ±    0 
 31 files    -   302     0 ❌ ±    0 

Results for commit e31edc6. ± Comparison against base commit 18b1028.

This pull request removes 2452 tests.
com.wire.android.GlobalObserversManagerTest ‑ given app not visible and valid session, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app not visible and valid session, when observing app open, then do not retry sending pending messages()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and invalid session, when app opens, then do not retry sending pending messages()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and invalid session, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and no session, when app opens, then do not retry sending pending messages()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and no session, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and session failure, when app opens, then do not retry sending pending messages()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and session failure, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and valid session, when app opens, then retry sending pending messages()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and valid session, when handling ephemeral messages, then call deleteEphemeralMessageEndDate()
…

♻️ This comment has been updated with latest results.

@ohassine
ohassine requested review from saleniuk and sbakhtiarov and removed request for sbakhtiarov August 20, 2026 11:53
* Once dismissed, the banner is not shown again for that conversation.
*/
@SingleIn(AppScope::class)
class ViewerAccessBannerStore @Inject constructor(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new store is not user-scoped and is not cleared on logout. Will it be possible to use existing UserDataStore here (need to move it into a core:datastore module)?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created datastore module and used UserDataStore here

…y-banner-on-Shared-drive-and-conversation

# Conflicts:
#	features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/CellViewModelTest.kt
@pull-request-size pull-request-size Bot added size/S and removed size/M labels Aug 26, 2026
@ohassine
ohassine requested a review from sbakhtiarov August 26, 2026 13:49
…ared-drive-and-conversation' into Display-viewer-only-banner-on-Shared-drive-and-conversation

# Conflicts:
#	kalium
@pull-request-size pull-request-size Bot added size/M and removed size/S labels Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants