feat: Display viewer only banner on shared drive and conversation (WPB-26394) - #5193
feat: Display viewer only banner on shared drive and conversation (WPB-26394)#5193ohassine wants to merge 9 commits into
Conversation
…y-banner-on-Shared-drive-and-conversation # Conflicts: # core/ui-common/src/main/res/drawable/ic_close.xml # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellsViewModelFactory.kt
Codecov Report❌ Patch coverage is Please upload reports for the commit e31edc6 to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## develop #5193 +/- ##
========================================
Coverage 52.45% 52.46%
========================================
Files 739 739
Lines 25702 25724 +22
Branches 4215 4219 +4
========================================
+ Hits 13481 13495 +14
- Misses 10933 10938 +5
- Partials 1288 1291 +3
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Test Results168 tests - 2 452 168 ✅ - 2 452 17s ⏱️ - 1m 8s Results for commit e31edc6. ± Comparison against base commit 18b1028. This pull request removes 2452 tests.♻️ This comment has been updated with latest results. |
| * Once dismissed, the banner is not shown again for that conversation. | ||
| */ | ||
| @SingleIn(AppScope::class) | ||
| class ViewerAccessBannerStore @Inject constructor( |
There was a problem hiding this comment.
This new store is not user-scoped and is not cleared on logout. Will it be possible to use existing UserDataStore here (need to move it into a core:datastore module)?
There was a problem hiding this comment.
Created datastore module and used UserDataStore here
…y-banner-on-Shared-drive-and-conversation # Conflicts: # features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/CellViewModelTest.kt
…y-banner-on-Shared-drive-and-conversation
…ared-drive-and-conversation' into Display-viewer-only-banner-on-Shared-drive-and-conversation # Conflicts: # kalium
https://wearezeta.atlassian.net/browse/WPB-26394
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Description:
Display viewer-only banner on Shared drive and conversation
In shared drive, if user closes the banner, it won't show up again.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.