Merge pull request #32 from wneessen/fix_possible_out-of-index_access

Fix possible out of index access

.github/workflows/codecov.yml

@@ -24,7 +24,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        go: [1.18]
+        go: ['1.22']
     steps:
     - name: Checkout Code
       uses: actions/checkout@master
@@ -34,7 +34,7 @@ jobs:
         go test -v -race --coverprofile=coverage.coverprofile --covermode=atomic .
     
     - name: Upload coverage to Codecov
-      if: success() && matrix.go == 1.18 && matrix.os == 'ubuntu-latest'
+      if: success() && matrix.go == '1.22' && matrix.os == 'ubuntu-latest'
       uses: codecov/codecov-action@v2
       with:
         token: ${{ secrets.CODECOV_TOKEN }} # not required for public repos

.github/workflows/codecov_testonly.yml

@@ -22,7 +22,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
-        go: [1.15, 1.16, 1.17, 1.18]
+        go: ['1.19', '1.20', '1.21', '1.22']
     steps:
     - name: Checkout Code
       uses: actions/checkout@master

.github/workflows/golangci-lint.yml

@@ -21,7 +21,7 @@ jobs:
     steps:
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.19
+          go-version: '1.22'
       - uses: actions/checkout@v3
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3

.github/workflows/sonarqube.yml

@@ -17,7 +17,7 @@ jobs:
       - name: Setup Go
         uses: actions/setup-go@v2.1.3
         with:
-          go-version: 1.18.x
+          go-version: 1.22.x
 
       - name: Run unit Tests
         run: |

.gitignore

@@ -14,4 +14,5 @@
 # Dependency directories (remove the comment below to include it)
 # vendor/
 
-examples/
+examples/
+.idea/

password.go

@@ -205,6 +205,9 @@ func (p *PwnedPassAPI) ListHashesPrefix(pf string) ([]Match, *http.Response, err
 	so := bufio.NewScanner(hr.Body)
 	for so.Scan() {
 		hp := strings.SplitN(so.Text(), ":", 2)
+		if len(hp) != 2 {
+			continue
+		}
 		fh := fmt.Sprintf("%s%s", strings.ToLower(pf), strings.ToLower(hp[0]))
 		hc, err := strconv.ParseInt(hp[1], 10, 64)
 		if err != nil {

password_test.go

@@ -431,7 +431,7 @@ func ExamplePwnedPassAPI_CheckPassword() {
 	if m != nil && m.Count != 0 {
 		fmt.Printf("Your password with the hash %q was found %d times in the pwned passwords DB\n",
 			m.Hash, m.Count)
-		// Output: Your password with the hash "a94a8fe5ccb19ba61c4c0873d391e987982fbbd3" was found 86495 times in the pwned passwords DB
+		// Output: Your password with the hash "a94a8fe5ccb19ba61c4c0873d391e987982fbbd3" was found 142835 times in the pwned passwords DB
 	}
 }
 
@@ -446,7 +446,7 @@ func ExamplePwnedPassAPI_CheckPassword_withPadding() {
 	if m != nil && m.Count != 0 {
 		fmt.Printf("Your password with the hash %q was found %d times in the pwned passwords DB\n",
 			m.Hash, m.Count)
-		// Output: Your password with the hash "a94a8fe5ccb19ba61c4c0873d391e987982fbbd3" was found 86495 times in the pwned passwords DB
+		// Output: Your password with the hash "a94a8fe5ccb19ba61c4c0873d391e987982fbbd3" was found 142835 times in the pwned passwords DB
 	}
 }
 
@@ -462,7 +462,7 @@ func ExamplePwnedPassAPI_checkSHA1() {
 	if m != nil && m.Count != 0 {
 		fmt.Printf("Your password with the hash %q was found %d times in the pwned passwords DB\n",
 			m.Hash, m.Count)
-		// Output: Your password with the hash "a94a8fe5ccb19ba61c4c0873d391e987982fbbd3" was found 86495 times in the pwned passwords DB
+		// Output: Your password with the hash "a94a8fe5ccb19ba61c4c0873d391e987982fbbd3" was found 142835 times in the pwned passwords DB
 	}
 }
 
@@ -478,6 +478,6 @@ func ExamplePwnedPassAPI_checkNTLM() {
 	if m != nil && m.Count != 0 {
 		fmt.Printf("Your password with the hash %q was found %d times in the pwned passwords DB\n",
 			m.Hash, m.Count)
-		// Output: Your password with the hash "0cb6948805f797bf2a82807973b89537" was found 86495 times in the pwned passwords DB
+		// Output: Your password with the hash "0cb6948805f797bf2a82807973b89537" was found 142835 times in the pwned passwords DB
 	}
 }