Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing API calls for subscribeddomains and breacheddomain #33

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

freman
Copy link
Contributor

@freman freman commented Apr 3, 2024

Added under breaches because that's where they fall in the documentation
https://haveibeenpwned.com/API/v3#SubscribedDomains

@wneessen
Copy link
Owner

wneessen commented Apr 3, 2024

Thanks so much for the PR: I'm going to review it within the next few days. It's currently a bit busy over here.

@wneessen
Copy link
Owner

wneessen commented Apr 3, 2024

Hi again @freman,
the change looks good to me. Could you please also add corresponding tests?

@freman
Copy link
Contributor Author

freman commented Apr 7, 2024

Hi again @freman, the change looks good to me. Could you please also add corresponding tests?

Hey, so, I do have tests but they're not really portable, testing subscribeddomains is relatively easy, I just check to see if the provided key has any domains and make sure it's parsing the json but breacheddomain not so much. I've opened a support ticket to see if hibp-integration-tests.com could possibly be added for testing that api.

Testing is limited by the lack of predictable response from upstream.

If you vote on this idea, you'll receive a notification when it's implemented: https://haveibeenpwned.uservoice.com/forums/275398-general/suggestions/48189713-implement-test-api-key-for-automated-domain-search
@freman
Copy link
Contributor Author

freman commented Apr 10, 2024

I've pushed up some tests, this is Troy's response from HIBP

If you vote on this idea, you'll receive a notification when it's implemented: https://haveibeenpwned.uservoice.com/forums/275398-general/suggestions/48189713-implement-test-api-key-for-automated-domain-search

@wneessen
Copy link
Owner

I've pushed up some tests, this is Troy's response from HIBP

If you vote on this idea, you'll receive a notification when it's implemented: https://haveibeenpwned.uservoice.com/forums/275398-general/suggestions/48189713-implement-test-api-key-for-automated-domain-search

Yeah, that's the answer I got for my last request as well ;) Thanks for trying anyways. The PR looks good to me and will be merged today. I'll probably issue a new release during the weekend.

@wneessen wneessen merged commit 1bff712 into wneessen:main Apr 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants