Fix(close): Access to nil variable causes panic #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wneessen
added a commit
that referenced
this pull request
Nov 6, 2024
Introduce a unit test to ensure that invoking Close on a nil smtpclient instance returns nil without errors. This enhances the robustness of the client closure functionality. This test accommodates the fix provided with PR #353
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
==========================================
- Coverage 91.74% 90.55% -1.19%
==========================================
Files 27 27
Lines 2944 2944
==========================================
- Hits 2701 2666 -35
- Misses 172 212 +40
+ Partials 71 66 -5 ☔ View full report in Codecov by Sentry. |
|
Could you create a minor release for this issue? I think it's a very critical one. It's happening for me, and I have to go around it with a defer recover. |
|
Yes, that should be possible. |
|
v0.5.2 is now released: https://github.com/wneessen/go-mail/releases/tag/v0.5.2 |
You are supersonic! Thank you very much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, accept this review for fixing a panic on the
.Close()method.