Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set file capabilities on some iptables executables #31207

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kranurag7
Copy link
Contributor

these file capabilities are required by linkerd-proxy-init at runtime to run as non-root user with UID of 65532.

@@ -70,6 +71,18 @@ pipeline:
install -D -m644 ebtables.confd "${{targets.destdir}}"/etc/conf.d/ebtables

subpackages:
- name: iptables-privileged
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the patch is in draft mode because we can discuss more on the package name here. I was thinking if we can name it as iptables-linkerd-compat similar to our bitnami variant of package where we name a package as *-bitnami-compat

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
@kranurag7
Copy link
Contributor Author

package update config check issue looks like one off and elastic build logs looks good from a quick skim.

Copy link
Contributor

@xnox xnox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if it has to be a separate package or not.

If container is in a username space those capabilities will not grant anything.

If docker / containerd / k8s / bubble wrap / flat pack / nspawn gave the namespace network capability things will just work.

I will check what other things use, but it is safer to grant capability on select binaries, rather than all binaries in a container / whole container. Cause I would have hoped we can get away with creating duplicate package because of permission settings like this.

iptables.yaml Outdated Show resolved Hide resolved
Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants