Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android/ios): support new arch #297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ngocle2497
Copy link

Migrate Android/IOS to new arch

@ngocle2497 ngocle2497 changed the title feat(android): migrate android feat(android/ío): support new arch May 9, 2024
@ngocle2497 ngocle2497 changed the title feat(android/ío): support new arch feat(android/ios): support new arch May 9, 2024
@ngocle2497 ngocle2497 marked this pull request as ready for review May 10, 2024 17:46
@ngocle2497
Copy link
Author

Hi @wonday can u review this PR

@taongocson
Copy link

@ngocle2497
i am using the library and getting error while rotating screen on IOS 16,
Do you have any solution please help me!

@ngocle2497
Copy link
Author

@ngocle2497 i am using the library and getting error while rotating screen on IOS 16, Do you have any solution please help me!

what the error?

@wonday
Copy link
Owner

wonday commented Jun 5, 2024

please fix the conflict

@karlhorky
Copy link

I guess this PR description can also have a line with Closes #272 added to it

@leo6104
Copy link

leo6104 commented Oct 5, 2024

iOS works well. (first moment it doesn't work but it was my project's misconfiguration in Info.pList)
However, android has error.

e: file:///home/runner/work/vscore-rn/vscore-rn/node_modules/react-native-orientation-locker/android/src/main/java/com/orientationlocker/OrientationLockerModule.kt:28:1 Class 'OrientationLockerModule' is not abstract and does not implement abstract base class member public abstract fun removeListeners(count: Double): Unit defined in com.orientationlocker.OrientationLockerSpec
e: file:///home/runner/work/vscore-rn/vscore-rn/node_modules/react-native-orientation-locker/android/src/main/java/com/orientationlocker/OrientationLockerModule.kt:277:3 'removeListeners' overrides nothing

Here is the error when install the branch and call gradlew assembleRelease in android project.

I installed your repository like this.

In package.json,

    "react-native-orientation-locker": "github:ngocle2497/react-native-orientation-locker#feat/new_arch",

@softgenicsShubham
Copy link

@leo6104 Ios also works fine for me and android have the same issues. have you find any solutions ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants