-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add useEffect to avoid multiple CES prompts on the Dashboard Page #1543
Open
jorgemd24
wants to merge
12
commits into
develop
Choose a base branch
from
fix/1428-ces-prompts-showing-several-times
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+370
−2
Open
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
74949bc
Add useEffect to avoid multiple CES prompts
jorgemd24 4ca8ac0
Add hook useUnmountableNotice
jorgemd24 c62f084
Add test hook unmountableNotice
jorgemd24 b0e9e9f
Add CESNotice
jorgemd24 1ac0a90
Add CESNotice tests
jorgemd24 28a819b
Refactor CustomerEffortScore component
jorgemd24 5a00fcf
Add tests for CustomerEffortScoreUnmountableNotice
jorgemd24 1e488d9
Replace CustomerEffortScore with CustomerEffortScoreUnmountableNotice
jorgemd24 dd18a9e
Remove useEffect to remove CES prompt in the dashboard component
jorgemd24 3a77cb4
Update CustomerEffortScoreUnmountableNotice description
jorgemd24 a22b042
Revert changes in dashboard.js - getQuery
jorgemd24 f674ca7
Update Give feedback domain CES Notice.
jorgemd24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/** | ||
* External dependencies | ||
*/ | ||
import { __ } from '@wordpress/i18n'; | ||
import { noop } from 'lodash'; | ||
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import useUnmountableNotice from '.~/hooks/useUnmountableNotice'; | ||
|
||
/** | ||
* Hook to create a CES notice | ||
* | ||
* @param {string} label CES prompt label. | ||
* @param {JSX.Element} icon Icon (React component) to be shown on the notice. | ||
* @param {Function} [onClickCallBack] Function to call when Give feedback is clicked. | ||
* @param {Function} [onNoticeDismissedCallback] Function to call when the notice is dismissed. | ||
* | ||
* @return {Function} a function that will create the CES notice. | ||
*/ | ||
const useCESNotice = ( | ||
label, | ||
icon, | ||
onClickCallBack = noop, | ||
onNoticeDismissedCallback = noop | ||
) => { | ||
return useUnmountableNotice( 'success', label, { | ||
actions: [ | ||
{ | ||
label: __( 'Give feedback', 'woocommerce-admin' ), | ||
onClick: onClickCallBack, | ||
}, | ||
], | ||
icon, | ||
explicitDismiss: true, | ||
onDismiss: onNoticeDismissedCallback, | ||
} ); | ||
}; | ||
|
||
export default useCESNotice; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be
google-listings-and-ads
rather thanwoocommerce-admin
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ianlin, it is updated: f674ca7
It is related to @wordpress/components, I think the issue is that @woocommerce/customer-effort-score/build/customer-feedback-modal uses a different version of @wordpress/components, and this increases the bundle size.
I am looking into possible solutions, maybe @ecgan have seen this issue before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment #1543 (comment) below.