Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unused methods from ProductMetaQueryHelper. #2370

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Delete unused methods from ProductMetaQueryHelper. #2370

wants to merge 1 commit into from
+0 −69

Conversation

jorgemd24
Copy link
Contributor

@jorgemd24 jorgemd24 commented Apr 15, 2024 •
edited
Loading

Changes proposed in this Pull Request:

While refactoring the Product Stats Overview section (already merged and released) I noticed that certain methods in ProductMetaQueryHelper are no longer use. Therefore, this PR removes those methods since they are not being used in the codebase.

  • ProductMetaQueryHelper::batch_insert_values
  • ProductMetaQueryHelper::batch_update_values

Screenshots:

Detailed test instructions:

  1. Double-check that batch_insert_values and batch_update_values are not used in the codebase.

Additional details:

Changelog entry

Tweak - Remove unused methods from ProductMetaQueryHelper

@jorgemd24 jorgemd24 self-assigned this Apr 15, 2024
@github-actions github-actions bot added the changelog: update Big changes to something that wasn't broken. label Apr 15, 2024
@jorgemd24 jorgemd24 marked this pull request as ready for review April 15, 2024 17:39
@jorgemd24 jorgemd24 requested a review from a team April 16, 2024 19:12
ianlin
ianlin approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@ianlin ianlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Tested locally using this branch and everything worked as expected. There are no more places using this two methods in the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianlin ianlin ianlin approved these changes

Assignees

@jorgemd24 jorgemd24

Labels
changelog: update Big changes to something that wasn't broken.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgemd24 @ianlin