Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit combo accounts #2660

Draft
wants to merge 168 commits into
base: feature/2509-consolidate-google-account-cards
Choose a base branch
from

Conversation

asvinb
Copy link
Collaborator

@asvinb asvinb commented Oct 31, 2024

Changes proposed in this Pull Request:

Closes # .

Replace this with a good description of your changes & reasoning.

Screenshots:

Detailed test instructions:

Additional details:

Changelog entry

asvinb and others added 30 commits October 3, 2024 20:28
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.8%. Comparing base (4f5bb47) to head (218149d).

Additional details and impacted files

Impacted file tree graph

@@                              Coverage Diff                              @@
##           feature/2509-consolidate-google-account-cards   #2660   +/-   ##
=============================================================================
  Coverage                                           62.7%   62.8%           
=============================================================================
  Files                                                325     325           
  Lines                                               5162    5165    +3     
  Branches                                            1265    1267    +2     
=============================================================================
+ Hits                                                3239    3242    +3     
  Misses                                              1746    1746           
  Partials                                             177     177           
Flag Coverage Δ
js-unit-tests 62.8% <100.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
js/src/components/account-card/index.js 91.9% <ø> (ø)
...ts/google-ads-account-card/claim-account-button.js 100.0% <100.0%> (ø)
js/src/hooks/useAutoCreateAdsMCAccounts.js 93.6% <100.0%> (-0.1%) ⬇️

asvinb and others added 29 commits October 31, 2024 19:46
This eliminates some unnecessary page.goto() calls to speed up the tests and reduce some inconsistencies.
…ce/google-listings-and-ads into update/2603-create-ads-account
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: update Big changes to something that wasn't broken.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants